I thinks it is ok to add scripting. Gary -------- Original message -------- From: Remko Popma <[email protected]> Date: 10/03/2015 17:36 (GMT-08:00) To: Log4J Developers List <[email protected]> Subject: Re: 2.4 web site
Compression is done, and I also fixed LOG4J2-1142 and LOG4J2-1050. Haven't looked at the scripting yet. Should we do a 2.4.1 without the scripting or include it (and name it 2.5)? On Tue, Sep 29, 2015 at 1:40 AM, Gary Gregory <[email protected]> wrote: I looked at the scripting feature at a high level today. Looks good, see my comments in the Jira. I did not look at the details in the private inner classes though. It seems like a 2.4.1 ASAP to fix the compression is important. Gary On Mon, Sep 28, 2015 at 4:25 PM, Remko Popma <[email protected]> wrote: I fixed the compression issue (LOG4J2-1135) but I don't think I will be able to look at the log4j: lookup issue (LOG4J2-1050). About that log4j lookup: some time ago when working on other issues I did notice that the context's configLocation property is null sometimes but I never really dug into when or why this happens. So I am not sure if this only happens with web-apps or whether it is because the config was not explicitly specified but loaded from the classpath... I hope someone else has time to look into this. The new scripting feature also looks very interesting but since I'm travelling I may not have time in the next few weeks to give it the attention it deserves. On Mon, Sep 28, 2015 at 4:07 PM, Remko Popma <[email protected]> wrote: Yes, I am. I have a fix and will commit soon. Will also try to add an extra unit test if time permits.... On Mon, Sep 28, 2015 at 3:57 PM, Ralph Goers <[email protected]> wrote: Remko, Are you working on the fix for the compression? Sent from my iPad On Sep 28, 2015, at 6:03 AM, Ralph Goers <[email protected]> wrote: Sorry Remko, I just realized you wrote the message and not Gary. Sent from my iPad On Sep 28, 2015, at 5:40 AM, Ralph Goers <[email protected]> wrote: At this point LOG4J2-1137 is just an idea. I have no idea when I would implement it. LOG4J2-1136 is code complete. I just have some. More documentation to write. I agree, fixing compression and the property substitution need to happen quickly. I don't know that I care whether the next release is 2.4.1 or 2.5. However I would like the scripting support in a release fairly quickly. I was hoping you and Remko would take a look at it and see if there is anything you would like to change. Ralph On Sep 28, 2015, at 5:05 AM, Remko Popma <[email protected]> wrote: Ralph, both scripting support (LOG4J2-1136) and buffering-until-trigger (LOG4J2-1137) seem like features that warrant a minor version increase (2.5) rather than a bugfix version increase (2.4.1). Is that what you have in mind? It looks like 2.4 broke compression on rollover (LOG4J2-1135). In my opinion this is a blocker for 2.4.1 (we really should include a fix for this). We can also look at the problem with property substitution (LOG4J2-1050) that Adam reported. Not sure if this is a 2.4.1 blocker, but since it is a new feature for 2.4 it is a bit embarrassing if it doesn't work. On Mon, Sep 28, 2015 at 1:35 PM, Mikael Ståldal <[email protected]> wrote: Can we fix it? On Fri, Sep 25, 2015 at 7:25 PM, Gary Gregory <[email protected]> wrote: That's because we fixed the site sources after the 2.4 RC was cut... Gary On Fri, Sep 25, 2015 at 9:49 AM, Mikael Ståldal <[email protected]> wrote: It seems like some Appenders, such as the new KafkaAppender, is missing from the menu. On Fri, Sep 25, 2015 at 5:01 AM, Ralph Goers <[email protected]> wrote: It only took about 2.5 hours (it has never been close to that long before) but the site is now deployed. Ralph On Sep 24, 2015, at 6:42 PM, Ralph Goers <[email protected]> wrote: You’ve never published our web site. It is huge. Ralph On Sep 24, 2015, at 6:05 PM, Gary Gregory <[email protected]> wrote: I'm tellin' ya, doing it all from p.a.o is faster ;-) Gary On Thu, Sep 24, 2015 at 5:48 PM, Ralph Goers <[email protected]> wrote: I am home now. It got some kind of server time out. I am trying again. Ralph On Sep 24, 2015, at 4:07 PM, Gary Gregory <[email protected]> wrote: Wow! Still no new site... G On Thu, Sep 24, 2015 at 11:06 AM, Gary Gregory <[email protected]> wrote: Too late now, but I what I've done in the past on other projects, is login to my people.apache.org account, build the site there, then publish it from there. Gary On Thu, Sep 24, 2015 at 11:01 AM, Ralph Goers <[email protected]> wrote: Me too. Unfortunately I did the commit from my personal Macbook at home and I am at work now. The commit had been going for about an hour when I had to leave.. I will have to check and see what happened when I get home this afternoon. Ralph On Sep 24, 2015, at 10:47 AM, Remko Popma <[email protected]> wrote: At the moment I still see the 2.3 web site. On Thu, Sep 24, 2015 at 10:54 PM, Ralph Goers <[email protected]> wrote: I tried again this morning and it seems to be working. It is now uploading to svn - which takes quite a while. Ralph On Sep 24, 2015, at 12:49 AM, Ralph Goers <[email protected]> wrote: No, I do not use a proxy. Ralph On Sep 24, 2015, at 12:13 AM, Gary Gregory <[email protected]> wrote: Are you using a proxy? Does this help: http://rubenlaguna.com/wp/2007/03/07/subversion-error-503-service-unavailable/ ? Gary -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Mikael Ståldal Senior software developer Magine TV [email protected] Regeringsgatan 25 | 111 53 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated in this message (or responsible for delivery of the message to such a person), you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Mikael Ståldal Senior software developer Magine TV [email protected] Regeringsgatan 25 | 111 53 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated in this message (or responsible for delivery of the message to such a person), you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
