[
https://issues.apache.org/jira/browse/LOG4J2-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma resolved LOG4J2-1124.
---------------------------------
Resolution: Won't Fix
The javadoc is correct: LogManager.getLogger() returns a logger for the calling
class.
I believe the misunderstanding is with what "calling class" means. This is not
the class where the {{logger.info("some message")}} method is called.
In your example, the calling class is {{AbstractBase}}, since that is where the
{{LogManager.getLogger()}} method is called.
> LogManager.getLogger()
> ----------------------
>
> Key: LOG4J2-1124
> URL: https://issues.apache.org/jira/browse/LOG4J2-1124
> Project: Log4j 2
> Issue Type: Bug
> Components: API
> Affects Versions: 2.3
> Environment: win64 java8 osgi
> Reporter: Hüseyin Kartal
> Assignee: Remko Popma
> Fix For: 2.4.1
>
>
> As in log4j2 api the LogManager.getLogger() call should return a logger for
> the calling class.
> {code}
> /**
> * Returns a Logger with the name of the calling class.
> * @return The Logger for the calling class.
> * @throws UnsupportedOperationException if the calling class cannot be
> determined.
> */
> public static Logger getLogger() {
> return getLogger(ReflectionUtil.getCallerClass(2));
> }
> {code}
> But in the following example the returned logger is get for the declaring
> AbstractLogger class and not as assumed for the calling Classes
> InstanceLogger and InstanceLogger2.
> {code}
> public class LogTest {
> protected class AbstractBase {
> Logger logger = LogManager.getLogger();
> public AbstractBase() {
> super();
> logger.info("init");
> }
> void log(String s) {
> logger.info(s);
> }
> }
> protected class InstanceBase extends AbstractBase {
> @Override
> void log(String s) {
> super.log(s);
> logger.info(s);
> }
> }
> protected class InstanceBase2 extends AbstractBase {
> @Override
> void log(String s) {
> super.log(s);
> logger.info(s);
> }
> }
> @Test
> public final void testLoggerInstance() {
> new InstanceBase().log("logging");
> new InstanceBase2().log("logging");
> }
> }
> {code}
> The Output is
> {code}
> 2015-09-18 13:51:21,830 INFO - main -
> d.z.w.l.LogUtilsTest$AbstractBase - [] * init -
>
> 2015-09-18 13:51:21,831 INFO - main -
> d.z.w.l.LogUtilsTest$AbstractBase - [] * logging -
>
> 2015-09-18 13:51:21,831 INFO - main -
> d.z.w.l.LogUtilsTest$AbstractBase - [] * logging -
>
> 2015-09-18 13:51:21,831 INFO - main -
> d.z.w.l.LogUtilsTest$AbstractBase - [] * init -
>
> 2015-09-18 13:51:21,831 INFO - main -
> d.z.w.l.LogUtilsTest$AbstractBase - [] * logging -
>
> 2015-09-18 13:51:21,831 INFO - main -
> d.z.w.l.LogUtilsTest$AbstractBase - [] * logging -
>
> {code}
> A workaround is to call *LogManager.getLogger(getClass())* but i assume that
> in most cases the logger for the calling class is needed so it would be nice
> to change the behaviour of LogManager.getLogger().
> The output of the workaround is
> {code}
> 2015-09-18 13:53:50,538 INFO - main -
> d.z.w.l.LogUtilsTest$InstanceBase - [] * init -
>
> 2015-09-18 13:53:50,538 INFO - main -
> d.z.w.l.LogUtilsTest$InstanceBase - [] * logging -
>
> 2015-09-18 13:53:50,538 INFO - main -
> d.z.w.l.LogUtilsTest$InstanceBase - [] * logging -
>
> 2015-09-18 13:53:50,543 INFO - main -
> d.z.w.l.LogUtilsTest$InstanceBase2 - [] * init -
>
> 2015-09-18 13:53:50,543 INFO - main -
> d.z.w.l.LogUtilsTest$InstanceBase2 - [] * logging -
>
> 2015-09-18 13:53:50,543 INFO - main -
> d.z.w.l.LogUtilsTest$InstanceBase2 - [] * logging -
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
