[
https://issues.apache.org/jira/browse/LOG4J2-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981893#comment-14981893
]
Ralph Goers commented on LOG4J2-1180:
-------------------------------------
I have concerns that this patch is going to cause problems. You have
effectively changed the name of the logger to include the messageFactory so %C
is going to print the wrong thing. However, I think you should still end up
with the correct LoggerConfig, but less efficiently since there will be a much
longer name to parse.
Saving the Logger in the map and including the FQCN could be OK, so long as it
isn't included in the logger name itself.
> Logger cache does not account for message factory
> -------------------------------------------------
>
> Key: LOG4J2-1180
> URL: https://issues.apache.org/jira/browse/LOG4J2-1180
> Project: Log4j 2
> Issue Type: Bug
> Components: API
> Affects Versions: 2.4.1
> Reporter: Gary Gregory
> Attachments: LOG4J2-1180.diff
>
>
> The Logger cache does not account for a logger's message factory.
> If you call {{LogManager.getLogger(Class|Object|String, MessageFactory)}} and
> then call a getLogger() API again with the same {{Class|Object|String}} a
> different message factory, you get the Logger that was first created which
> means you will not get the proper formatted messages.
> For example:
> {code:java}
> Logger loggerA1 = LogManager.getLogger("A", messageFactory1);
> Logger loggerA2 = LogManager.getLogger("A", messageFactory2);
> {code}
> loggerA1 is the same as loggerA2.
> This is a problem if two unrelated code bases (jars) both the same Logger
> names|objects|classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]