Pushed to master. On 9 November 2015 at 15:40, Matt Sicker <[email protected]> wrote:
> Gotta move all four string methods for this to work. I'll make them all > public for now. > > On 9 November 2015 at 15:17, Matt Sicker <[email protected]> wrote: > >> Yeah, I can move that over. >> >> On 9 November 2015 at 15:15, Ralph Goers <[email protected]> >> wrote: >> >>> Fishing? In LA? Oh that’s right you are actually south of LA. Still I >>> hope you are going out to deep water where the water is cleaner. >>> >>> Ralph >>> >>> On Nov 9, 2015, at 1:56 PM, Gary Gregory <[email protected]> wrote: >>> >>> Well, let's start with StringEncoder in Core utils... can you do that? >>> I'm off today, taking my son fishing for his birthday... >>> >>> Gary >>> >>> On Mon, Nov 9, 2015 at 12:36 PM, Matt Sicker <[email protected]> wrote: >>> >>>> Depends if we want to add any other non-encoding string utility >>>> functions to that or keep them separate. If separate, then StringEncoder >>>> sounds fine to me. >>>> >>>> On 9 November 2015 at 14:33, Gary Gregory <[email protected]> >>>> wrote: >>>> >>>>> How about a Core StringEncoder util class? >>>>> >>>>> We have a "Strings" class in the API util package, so it seems odd to >>>>> have another "Strings" util class in the Core util package. >>>>> >>>>> Gary >>>>> >>>>> On Mon, Nov 9, 2015 at 12:30 PM, Gary Gregory <[email protected]> >>>>> wrote: >>>>> >>>>>> Well, we could keep it in the core util for now, the question is >>>>>> where? >>>>>> >>>>>> Gary >>>>>> >>>>>> On Mon, Nov 9, 2015 at 12:23 PM, Matt Sicker <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> I'd like to keep the API util to very low-level utility things >>>>>>> needed by the API, too. >>>>>>> >>>>>>> On 9 November 2015 at 11:49, Gary Gregory <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> On Mon, Nov 9, 2015 at 8:06 AM, Mikael Ståldal < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Can we make AbstractStringLayout.toBytes(String, Charset) public? >>>>>>>>> >>>>>>>>> I would like to use it in KafkaAppender. >>>>>>>>> >>>>>>>>> If I understand it correctly, it is supposed to be more efficient >>>>>>>>> than String.getBytes(Charset). >>>>>>>>> >>>>>>>> >>>>>>>> We could move this to a new Strings class in >>>>>>>> org.apache.logging.log4j.*core*.util or to the >>>>>>>> existing org.apache.logging.log4j.*util*.Strings. I'm just not >>>>>>>> crazy about turning org.apache.logging.log4j.util into a kitchen sink. >>>>>>>> >>>>>>>> Gary >>>>>>>> >>>>>>>> >>>>>>>>> -- >>>>>>>>> [image: MagineTV] >>>>>>>>> >>>>>>>>> *Mikael Ståldal* >>>>>>>>> Senior software developer >>>>>>>>> >>>>>>>>> *Magine TV* >>>>>>>>> [email protected] >>>>>>>>> Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com >>>>>>>>> >>>>>>>>> Privileged and/or Confidential Information may be contained in >>>>>>>>> this message. If you are not the addressee indicated in this message >>>>>>>>> (or responsible for delivery of the message to such a person), you >>>>>>>>> may not copy or deliver this message to anyone. In such case, >>>>>>>>> you should destroy this message and kindly notify the sender by >>>>>>>>> reply email. >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>> <http://www.manning.com/bauer3/> >>>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>> Home: http://garygregory.com/ >>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Matt Sicker <[email protected]> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> E-Mail: [email protected] | [email protected] >>>>>> Java Persistence with Hibernate, Second Edition >>>>>> <http://www.manning.com/bauer3/> >>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>> Blog: http://garygregory.wordpress.com >>>>>> Home: http://garygregory.com/ >>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> E-Mail: [email protected] | [email protected] >>>>> Java Persistence with Hibernate, Second Edition >>>>> <http://www.manning.com/bauer3/> >>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>> Blog: http://garygregory.wordpress.com >>>>> Home: http://garygregory.com/ >>>>> Tweet! http://twitter.com/GaryGregory >>>>> >>>> >>>> >>>> >>>> -- >>>> Matt Sicker <[email protected]> >>>> >>> >>> >>> >>> -- >>> E-Mail: [email protected] | [email protected] >>> Java Persistence with Hibernate, Second Edition >>> <http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >>> >>> >> >> >> -- >> Matt Sicker <[email protected]> >> > > > > -- > Matt Sicker <[email protected]> > -- Matt Sicker <[email protected]>
