[ 
https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029679#comment-15029679
 ] 

Remko Popma commented on LOG4J2-435:
------------------------------------

Good catch. We could also do work to guarantee the order in property file 
configurations.

Let's look at this from the user's perspective. Would you want these two 
configurations to work the same way or differently? And what would you expect 
these to do?

{code}
(1)
<Delete baseDir="${sys:base}">
  <IfFileName glob="test-*.log" />
  <IfAccumulatedFileCount exceeds="5" />
</Delete>

(2)
<Delete baseDir="${sys:base}">
  <IfAccumulatedFileCount exceeds="5" />
  <IfFileName glob="test-*.log" />
</Delete>
{code}

I assumed that users want to keep the my-\*.log files and delete the 
test-\*.log files until the most recent 5 remain. Your suggestion to always 
execute all filters would not accomplish this (more recent my-\*.log files 
consume the count that was intented for the test-\*.log files).

> Feature request: auto-delete older log files 
> ---------------------------------------------
>
>                 Key: LOG4J2-435
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-435
>             Project: Log4j 2
>          Issue Type: Improvement
>            Reporter: Arkin Yetis
>            Assignee: Remko Popma
>              Labels: Rollover
>             Fix For: 2.5
>
>         Attachments: LimitingRolloverStrategy.java, SizeParser.java
>
>
> Original description:
> {quote}
> DefaultRolloverStrategy max attribute only applies if you have a %i in the 
> file pattern. This request is to enhance DefaultRolloverStrategy or another 
> appropriate component to allow a max number of files limit to apply across 
> days/months/years when a filePattern includes a date pattern.
> {quote}
> ----
> One of the most requested features is to add the ability to Log4j to "clean 
> up" older log files.  This usually means deleting these files, although it 
> could also mean moving them to a different location, or some combination of 
> these. 
> Users have different requirements for selecting the files to clean up. A 
> common request is the ability to keep the last X number of log files. This 
> works well if rollover is only date based but may give undesired results with 
> size based rollover. 
> Another factor to consider is that the directory containing the log files may 
> contain the log files for multiple appenders, or even files unrelated to 
> logging. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to