Is a flow message factory a kind of message factory or a different kind of
factory?

Does a logger need instances of both or just the one?

Since entry message extends message, should the factory do so as well?

Gary, phone, typos.
On Feb 18, 2016 8:44 AM, "Remko Popma" <[email protected]> wrote:

> Would anyone mind terribly if I factored out the FlowMessage creation
> methods from MessageFactory to a new interface FlowMessageFactory?
>
> Concretely, this interface would contain the methods introduced in
> LOG4J2-1255:
>
> EntryMessage newEntryMessage(Message message);
> ExitMessage newExitMessage(Object object, Message message);
> ExitMessage newExitMessage(EntryMessage message);
> ExitMessage newExitMessage(Object object, EntryMessage message);
>
> I think flow messages are different enough from normal Messages that a 
> separate factory makes sense.
>
> It would also insulate users who created a custom MessageFactory from the 
> changes we made in LOG4J2-1255.
>
> Thoughts?
>
> -Remko
>
>
>

Reply via email to