Yeah probably. Just note it in the release notes? On 1 March 2016 at 12:50, Gary Gregory <[email protected]> wrote:
> Yeah, I did not add custom read/write, perhaps it's a YAGNI item? > > Gary > > On Tue, Mar 1, 2016 at 10:11 AM, Matt Sicker <[email protected]> wrote: > >> New fields is backwards compatible, but not forwards compatible. You >> could add custom readObject and writeObject methods if we really need BC >> and FC. >> >> On 1 March 2016 at 11:40, Gary Gregory <[email protected]> wrote: >> >>> New fields for thread ID and thread priority in the log event class, >>> which is of course serializable. >>> >>> Gary >>> On Mar 1, 2016 8:27 AM, "Matt Sicker" <[email protected]> wrote: >>> >>>> How does it break serialization? >>>> >>>> On 1 March 2016 at 10:13, Gary Gregory (JIRA) <[email protected]> wrote: >>>> >>>>> >>>>> [ >>>>> https://issues.apache.org/jira/browse/LOG4J2-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173959#comment-15173959 >>>>> ] >>>>> >>>>> Gary Gregory commented on LOG4J2-1299: >>>>> -------------------------------------- >>>>> >>>>> My patch is almost ready. Note that this will break log event >>>>> serialization with 2.5. >>>>> >>>>> > Add pattern converter for thread id in PatternLayout >>>>> > ---------------------------------------------------- >>>>> > >>>>> > Key: LOG4J2-1299 >>>>> > URL: >>>>> https://issues.apache.org/jira/browse/LOG4J2-1299 >>>>> > Project: Log4j 2 >>>>> > Issue Type: Improvement >>>>> > Components: Core, Pattern Converters >>>>> > Affects Versions: 2.5 >>>>> > Reporter: Remko Popma >>>>> > Assignee: Gary Gregory >>>>> > >>>>> > As requested here: >>>>> > >>>>> http://stackoverflow.com/questions/14359044/display-thread-id-instead-thread-name-in-log >>>>> >>>>> >>>>> >>>>> -- >>>>> This message was sent by Atlassian JIRA >>>>> (v6.3.4#6332) >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>>> >>>> >>>> >>>> -- >>>> Matt Sicker <[email protected]> >>>> >>> >> >> >> -- >> Matt Sicker <[email protected]> >> > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <[email protected]>
