I never really wanted to do includes. I would prefer to support multiple configuration files that are merged - see LOG4J2-494. I view the XInclude for XML files as a special case.
If I did want to support includes I would not want to allow a monitorInterval on the include element. The value on the configuration should be used. I have no idea what it would mean to have a monitorInterval of 0 on the main configuration and a non-zero value on an include. Likewise, having a main monitorInterval of 60 and an interval of 30 on an include also doesn’t seem right. Ralph > On Mar 2, 2016, at 11:39 AM, Gary Gregory <[email protected]> wrote: > > Stemming from discussion in https://github.com/apache/logging-log4j2/pull/25 > <https://github.com/apache/logging-log4j2/pull/25> > > How about finally adding our own include mechanism: > > <Include monitorIntervalSeconds="60">file://...</Include> > > If Configuration has a monitorInterval, then Includes inherit the setting, if > you set an Include monitorInterval to 0 then, then it is not watched. > > Thoughts? > > Gary > > -- > E-Mail: [email protected] <mailto:[email protected]> | > [email protected] <mailto:[email protected]> > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> > Home: http://garygregory.com/ <http://garygregory.com/> > Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
