[ 
https://issues.apache.org/jira/browse/LOG4J2-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182249#comment-15182249
 ] 

Matt Sicker commented on LOG4J2-1050:
-------------------------------------

I get an error when I try to apply that patch to master:

{code}
$ git apply ~/Downloads/fix-log4jlookup.patch.txt
/Users/matt/Downloads/fix-log4jlookup.patch.txt:94: trailing whitespace.
import org.apache.logging.log4j.core.config.Configuration;
/Users/matt/Downloads/fix-log4jlookup.patch.txt:103: trailing whitespace.
    public final void formatFileName(final Configuration config, final 
StrSubstitutor subst, final StringBuilder buf, final Object obj) {
/Users/matt/Downloads/fix-log4jlookup.patch.txt:110: trailing whitespace.
        final String fileName = subst.replace(config, event, buf);
/Users/matt/Downloads/fix-log4jlookup.patch.txt:123: trailing whitespace.
        return Paths.get(subst.replace(null, getBasePathString()));
/Users/matt/Downloads/fix-log4jlookup.patch.txt:220: trailing whitespace.
                final String value = getStrSubstitutor().replace(this, 
entry.getValue());
error: patch failed: 
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java:24
error: 
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java:
 patch does not apply
error: patch failed: 
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/AbstractPathAction.java:103
error: 
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/AbstractPathAction.java:
 patch does not apply
error: patch failed: 
log4j-core/src/main/java/org/apache/logging/log4j/core/config/json/JsonConfiguration.java:71
error: 
log4j-core/src/main/java/org/apache/logging/log4j/core/config/json/JsonConfiguration.java:
 patch does not apply
error: patch failed: 
log4j-web/src/main/java/org/apache/logging/log4j/web/Log4jWebInitializerImpl.java:96
error: 
log4j-web/src/main/java/org/apache/logging/log4j/web/Log4jWebInitializerImpl.java:
 patch does not apply
{code}

> Add a Log4jLookup class to help write log files relative to log4j2.xml
> ----------------------------------------------------------------------
>
>                 Key: LOG4J2-1050
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1050
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Configurators
>    Affects Versions: 2.3
>         Environment: All
>            Reporter: adam Retter
>            Priority: Critical
>             Fix For: 2.4, 2.4.1, 2.6
>
>         Attachments: 
> 0001-feature-Added-support-for-properties-interpolation-o.patch, 
> fix-log4jlookup.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I attach a patch related to this mailing list post - 
> http://mail-archives.apache.org/mod_mbox/logging-log4j-user/201506.mbox/%3CCAPK0icj%3DY3T9ptBGyGdgbHyMow_YWcfwC6UdLHS-QbgnBk8wkA%40mail.gmail.com%3E
> The patch makes the properties `log4j:configLocation` and 
> `log4j:configParentLocation` available for substitution in the log4j 
> configuration file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to