[
https://issues.apache.org/jira/browse/LOG4J2-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216140#comment-15216140
]
Remko Popma edited comment on LOG4J2-1329 at 3/29/16 3:08 PM:
--------------------------------------------------------------
{quote}
Do we want to have gc-free logging with other layouts than PatternLayout?
{quote}
Absolutely! When we first started discussing gc-free related changes to Layout
in LOG4J2-1274, I proposed that we initially target the PatternLayout +
RandomAccessFileAppender combination and address other Layouts and Appenders
when we were happy with the results. So far I have not seen any problems, but
not sure how may other layouts we want to update in this release. I have no
problem with the GelfLayout being gc-free in this release.
That said, to me the main theme of this release is *gc-free logging*. If the
choice is between being gc-free and copy-free, I choose gc-free. To be
copy-free _in addition to_ gc-free is a nice to have optimization.
was (Author: [email protected]):
{quote}
Do we want to have gc-free logging with other layouts than PatternLayout?
{quote}
Absolutely! When we first started discussing gc-free related changes to Layout
in LOG4J2-1274, I proposed that we initially target the PatternLayout +
RandomAccessFileAppender combination and address other Layouts and Appenders
when we were happy with the results. So far I have not seen any problems, but
not sure how may other layouts we want to update in this release. I have no
problem with the GelfLayout being gc-free in this release.
> API change: let Message.getFormattedMessage() return CharSequence instead of
> String
> -----------------------------------------------------------------------------------
>
> Key: LOG4J2-1329
> URL: https://issues.apache.org/jira/browse/LOG4J2-1329
> Project: Log4j 2
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.5
> Reporter: Remko Popma
>
> I propose that we change {{Message.getFormattedMessage()}} to return a
> {{CharSequence}} instead of a String.
> I believe this change would be backwards compatible (all Message
> implementations that return a String will work as is), and it opens the way
> for zero-GC Message implementations to return a cached StringBuilder as
> Mikael [suggested on the log4j-dev mailing
> list|http://mail-archives.apache.org/mod_mbox/logging-log4j-dev/201603.mbox/%3CCAAFrFhSs4EqjOERwHObKAZP4wjGWeiCET1nyE1FVndYdePk2yw%40mail.gmail.com%3E].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
