[ 
https://issues.apache.org/jira/browse/LOG4J2-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244688#comment-15244688
 ] 

Greg Thomas commented on LOG4J2-1348:
-------------------------------------

That sounds like a good idea (wish I'd though of it!); to make it more 
explicit, it would be called like ...

{{CloseableThreadContext.Instance ctc = 
CloseableThreadContext.put(...).put(...)}}

i.e. the static method {{CloseableThreadContext.put()}} returns an instance of 
an object of type CloseableThreadContext.Instance - and the instance method 
{{put()}} of  CloseableThreadContext.Instance returns {{this}}. I'll rework 
accordingly ...

> Add an AutoCloseable ThreadContext class: CloseableThreadContext
> ----------------------------------------------------------------
>
>                 Key: LOG4J2-1348
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1348
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>            Reporter: Greg Thomas
>            Assignee: Gary Gregory
>            Priority: Minor
>             Fix For: 2.6
>
>         Attachments: CloseableThreadContext.zip, ctc-also.patch, ctc.patch, 
> thread-context.xml.patch
>
>
> The log4j2 API provides a ThreadContext - 
> https://logging.apache.org/log4j/2.x/manual/thread-context.html -  that 
> allows items to be added to a stack or a map for logging, and then 
> subsequently removed once they are no longer required.
> This sounds like an ideal candidate for a AutoCloseable implementation so 
> that items are removed automatically and no longer left around littering the 
> stack/map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to