[ 
https://issues.apache.org/jira/browse/LOG4J2-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249895#comment-15249895
 ] 

Kamal Mettananda commented on LOG4J2-1372:
------------------------------------------

I analysed the code, and this is related to the way the 
org.apache.logging.log4j.core.layout.XmlLayout writes the XML file using all 
the Events including a header and a footer. 

When <Event>s are written into a XML file; the "Event" object is not the root 
element, but an element named <Events>; created using XmlLayout#getHeader() and 
XmlLayout#getFooter() methods.

com.fasterxml.jackson.dataformat.xml.util.DefaultXmlPrettyPrinter is used to 
print the Event object into an XML; hence it assumes <Event> tag as the root 
element, so it prints the <Event> tag without any indentation. So both <Events> 
and <Event> tags are having the same (zero) indentation.

> XMLLayout indents, but not the first child tag (<Event>)
> --------------------------------------------------------
>
>                 Key: LOG4J2-1372
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1372
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Layouts
>    Affects Versions: 2.5
>            Reporter: Kamal Mettananda
>            Priority: Minor
>
> I am using log4j 2.5 to print the logs via XMLLayout. I have set 
> compact="true", hence the new line and indents of sub tags work correctly. 
> However I have noticed that the first child tag is not indented correctly. 
> Following is such a sample where <Events> and <Event> are at the same indent 
> level (0 indent). 
> {code:xml}
> <?xml version="1.0" encoding="UTF-8"?>
> <Events xmlns="http://logging.apache.org/log4j/2.0/events";>
> <Event xmlns="http://logging.apache.org/log4j/2.0/events"; 
> timeMillis="1460974404123" thread="main" level="INFO" 
> loggerName="com.foo.Bar" endOfBatch="true" 
> loggerFqcn="org.apache.logging.log4j.spi.AbstractLogger" threadId="11" 
> threadPriority="5">
>   <Message>Message flushed with immediate flush=false</Message>
> </Event>
> <Event xmlns="http://logging.apache.org/log4j/2.0/events"; 
> timeMillis="1460974404133" thread="main" level="INFO" 
> loggerName="com.foo.Bar" endOfBatch="true" 
> loggerFqcn="org.apache.logging.log4j.spi.AbstractLogger" threadId="11" 
> threadPriority="5">
>   <Message>Message flushed with immediate flush=false</Message>
> </Event>
> </Events>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to