Maybe not, if we assume that most users won't use UTF-16. (I don't use UTF-16, and I don't know any specific use case for it. I just thought it would be good to test it.)
There is no significant difference for US-ASCII, ISO-8859-1 and UTF-8. On Wed, May 18, 2016 at 6:02 PM, Remko Popma <[email protected]> wrote: > Interesting. I'll take a look tomorrow. > I don't think this is a showstopper though, would you agree? > > On Thu, May 19, 2016 at 12:29 AM, Mikael Ståldal < > [email protected]> wrote: > >> It seems like the new garbage-free string encoding method performs poorly >> with the UTF-16 charset. >> >> See AbstractStringLayoutStringEncodingBenchmark in log4j-perf which I >> just committed to master branch. >> >> My results, note utf16Encode: >> >> Benchmark Mode Samples Score Error Units >> baseline sample 90395 24.754 ± 0.484 ns/op >> iso8859_1Encode sample 54514 130.176 ± 2.320 ns/op >> iso8859_1GetBytes sample 64464 126.122 ± 1.184 ns/op >> usAsciiEncode sample 68833 190.550 ± 1.117 ns/op >> usAsciiGetBytes sample 80176 170.556 ± 1.691 ns/op >> utf16Encode sample 86597 2013.954 ± 10.551 ns/op >> utf16GetBytes sample 63696 386.276 ± 46.024 ns/op >> utf8Encode sample 69108 190.773 ± 1.504 ns/op >> utf8GetBytes sample 66561 196.247 ± 1.623 ns/op >> >> -- >> [image: MagineTV] >> >> *Mikael Ståldal* >> Senior software developer >> >> *Magine TV* >> [email protected] >> Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com >> >> Privileged and/or Confidential Information may be contained in this >> message. If you are not the addressee indicated in this message >> (or responsible for delivery of the message to such a person), you may >> not copy or deliver this message to anyone. In such case, >> you should destroy this message and kindly notify the sender by reply >> email. >> > > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* [email protected] Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated in this message (or responsible for delivery of the message to such a person), you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email.
