That would be good. I try to remember to add @since everywhere I can
remember to, but an automated tool would help a lot.
On 29 May 2016 at 12:02, Gary Gregory <garydgreg...@gmail.com> wrote:
> On Sun, May 29, 2016 at 9:57 AM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
>
>> And to make it more difficult to see what's changed, we do not have
>> @since 2.6 Javadoc markers for the new methods in Logger that expand
>> arguments up to 10 Objects :-(
>>
>
> I wonder which one of Clirr or Checkstyle could be extended to issue
> warnings if @since tags are missing on public methods?
>
> Gary
>
>>
>> Gary
>>
>> On Sun, May 29, 2016 at 9:53 AM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> We are going to need to update the release notes and/or site for 2.6 to
>>> note that the 2.6 is not source compatible with previous releases. I tested
>>> going from 2.5 to 2.6 at work and got:
>>>
>>> [ERROR] COMPILATION ERROR :
>>> [INFO] -------------------------------------------------------------
>>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>> both method
>>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>>> org.apache.logging.log4j.Logger and method
>>> error(java.lang.String,java.lang.Object,java.lang.Object) in
>>> org.apache.logging.log4j.Logger match
>>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>> both method
>>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>>> org.apache.logging.log4j.Logger and method
>>> trace(java.lang.String,java.lang.Object,java.lang.Object) in
>>> org.apache.logging.log4j.Logger match
>>> [INFO] 2 errors
>>>
>>> with source code like:
>>>
>>> public void xyz(final String message, final Throwable t) {
>>> ...
>>> logger.error(null, message, t);
>>> ...
>>> logger.trace(null, message, t);
>>> ...
>>> }
>>>
>>> Next time, I'll remember to test with a "real" client.
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Matt Sicker <boa...@gmail.com>
