Great, TY.
Gary
On May 29, 2016 8:20 PM, "Ralph Goers" <ralph.go...@dslextreme.com> wrote:
> I added the same information to the main site page.
>
> Ralph
>
> On May 29, 2016, at 2:08 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> On Sun, May 29, 2016 at 1:41 PM, Ralph Goers <ralph.go...@dslextreme.com>
> wrote:
>
>> Here is the text that I propose to add to the announcement. I would also
>> add something similar to the web site.
>>
>> Note that subsequent to the release a minor source incompatibility was
>> found due to the addition of new methods to
>> the Logger interface. If you have code that does:
>>
>> logger.error(null, “This is the log message”, throwable);
>>
>> or similar with any log level you will get a compiler error saying the
>> reference is ambiguous. To correct this either do:
>>
>> logger.error(“This is the log message”, throwable);
>>
>> or
>>
>> logger.error((Marker) null, “This is the log message”, throwable);
>>
>>
> I would add that the 2.6 code is _binary_ compatible with previous
> releases.
>
> Gary
>
>
>>
>> Ralph
>>
>> On May 29, 2016, at 11:14 AM, Matt Sicker <boa...@gmail.com> wrote:
>>
>> Yet another reason to hate null! ;)
>>
>> On 29 May 2016 at 13:13, Ralph Goers <ralph.go...@dslextreme.com> wrote:
>>
>>> When you pass null as the first argument it doesn't know which is better
>>>
>>> Sent from my iPhone
>>>
>>> On May 29, 2016, at 11:07 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>> Wait, how are error(Marker, String, Object) and error(String, Object,
>>> Object) even confused by the compiler?
>>>
>>> On 29 May 2016 at 13:02, Ralph Goers <ralph.go...@dslextreme.com> wrote:
>>>
>>>> Only if the compatibility issue can be fixed. I don't think it can. We
>>>> will just update the site and announcement.
>>>>
>>>> Sent from my iPhone
>>>>
>>>> On May 29, 2016, at 10:56 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>> So what do we do, follow up with 2.6.1 right away?
>>>>
>>>> On 29 May 2016 at 12:29, Ralph Goers <ralph.go...@dslextreme.com>
>>>> wrote:
>>>>
>>>>> Can’t do that. That would require a re-release.
>>>>>
>>>>> Speaking of which, the archives directory only lists a couple of
>>>>> releases. I thought they were all supposed to be there.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On May 29, 2016, at 10:19 AM, Gary Gregory <garydgreg...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> I think the RELEASE-NOTES.txt in the dist area needs to be updated as
>>>>> well.
>>>>>
>>>>> Gary
>>>>>
>>>>> On Sun, May 29, 2016 at 10:15 AM, Ralph Goers <
>>>>> ralph.go...@dslextreme.com> wrote:
>>>>>
>>>>>> I will add something to the announcement text when I send out the
>>>>>> emails. Those will go out in a few hours.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On May 29, 2016, at 9:53 AM, Gary Gregory <garydgreg...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>> We are going to need to update the release notes and/or site for 2.6
>>>>>> to note that the 2.6 is not source compatible with previous releases. I
>>>>>> tested going from 2.5 to 2.6 at work and got:
>>>>>>
>>>>>> [ERROR] COMPILATION ERROR :
>>>>>> [INFO] -------------------------------------------------------------
>>>>>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>>>>> both method
>>>>>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object)
>>>>>> in
>>>>>> org.apache.logging.log4j.Logger and method
>>>>>> error(java.lang.String,java.lang.Object,java.lang.Object) in
>>>>>> org.apache.logging.log4j.Logger match
>>>>>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>>>>> both method
>>>>>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object)
>>>>>> in
>>>>>> org.apache.logging.log4j.Logger and method
>>>>>> trace(java.lang.String,java.lang.Object,java.lang.Object) in
>>>>>> org.apache.logging.log4j.Logger match
>>>>>> [INFO] 2 errors
>>>>>>
>>>>>> with source code like:
>>>>>>
>>>>>> public void xyz(final String message, final Throwable t) {
>>>>>> ...
>>>>>> logger.error(null, message, t);
>>>>>> ...
>>>>>> logger.trace(null, message, t);
>>>>>> ...
>>>>>> }
>>>>>>
>>>>>> Next time, I'll remember to test with a "real" client.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> <http://www.manning.com/bauer3/>
>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <boa...@gmail.com>
>>>>
>>>>
>>>
>>>
>>> --
>>> Matt Sicker <boa...@gmail.com>
>>>
>>>
>>
>>
>> --
>> Matt Sicker <boa...@gmail.com>
>>
>>
>> --------------------------------------------------------------------- To
>> unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For
>> additional commands, e-mail: log4j-dev-h...@logging.apache.org
>
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
