I created the fix and tested it. The test works when I run it standalone but fails when I run all tests. I am not sure why. One way or another I plan to create the release today.
Ralph > On Jun 5, 2016, at 4:23 AM, Remko Popma <remko.po...@gmail.com> wrote: > > Is the footer being written twice in LOG4J2-1405 a showstopper for 2.6.1? > If this is an easy fix I'd say go for it, but otherwise perhaps it makes > sense to release what's in master now. > > Especially LOG4J2-1409 (the ArrayIndexOutOfBoundsException) > and LOG4J2-1406 (getting stuck on a previously logged Exception) > are critical bugs and I'd like to release the fix for these as soon as > possible... > > > >> On Sat, Jun 4, 2016 at 5:54 AM, Ralph Goers <ralph.go...@dslextreme.com> >> wrote: >> Actually, nevermind. I know how to do it. >> >> Ralph >> >>> On Jun 3, 2016, at 1:32 PM, Gary Gregory <garydgreg...@gmail.com> wrote: >>> >>> I can make on from the jpeg tonight or tomorrow. AFK. >>> >>> Gary >>> >>>> On Jun 3, 2016 1:26 PM, "Ralph Goers" <ralph.go...@dslextreme.com> wrote: >>>> A png. >>>> >>>> Ralph >>>> >>>>> On Jun 3, 2016, at 12:11 PM, Gary Gregory <garydgreg...@gmail.com> wrote: >>>>> >>>>>> On Fri, Jun 3, 2016 at 11:50 AM, Ralph Goers >>>>>> <ralph.go...@dslextreme.com> wrote: >>>>>> Do we have one of the standard logo? I can do that before I generate the >>>>>> site. >>>>> >>>>> I'm sorry one of what? >>>>> >>>>> Gary >>>>> >>>>>> >>>>>> Ralph >>>>>> >>>>>>> On Jun 3, 2016, at 11:11 AM, Gary Gregory <garydgreg...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> On Fri, Jun 3, 2016 at 10:51 AM, Gary Gregory <garydgreg...@gmail.com> >>>>>>>> wrote: >>>>>>>>> On Fri, Jun 3, 2016 at 10:21 AM, Ralph Goers >>>>>>>>> <ralph.go...@dslextreme.com> wrote: >>>>>>>>> Gary, can you modify another logo for 2.6.1. Just pick the one in the >>>>>>>>> chart preceding the one for 2.6. >>>>>>>> >>>>>>>> Sure. >>>>>>> >>>>>>> See /log4j-parent/src/site/resources/logo/logo-lightning-2.6.1.png >>>>>>> >>>>>>> You should switch the site to use a png instead of a jpeg IMO. >>>>>>> >>>>>>> Gary >>>>>>> >>>>>>>> >>>>>>>> G >>>>>>>>> >>>>>>>>> Ralph >>>>>>>>> >>>>>>>>>> On Jun 3, 2016, at 10:16 AM, Ralph Goers >>>>>>>>>> <ralph.go...@dslextreme.com> wrote: >>>>>>>>>> >>>>>>>>>> Thanks Remko. Just remember that “tonight” or “tomorrow morning” >>>>>>>>>> translates into 12-24 hrs from now. So if you have more you want to >>>>>>>>>> do when you get up you have some time. >>>>>>>>>> >>>>>>>>>> Ralph >>>>>>>>>> >>>>>>>>>>> On Jun 3, 2016, at 10:03 AM, Remko Popma <remko.po...@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> I fixed two critical issues introduced by 2.6. >>>>>>>>>>> It would be great if Matt can take a look at LOG4J2-1394 (I did a >>>>>>>>>>> bit but there's still quite a few remaining). >>>>>>>>>>> >>>>>>>>>>> Not sure if LOG4J2-1405 was introduced by 2.6 since the user >>>>>>>>>>> upgraded from 2.3. However it's 2 am here and I'm done for day. >>>>>>>>>>> >>>>>>>>>>> I'm good with releasing 2.6.1 with the current batch of fixes. >>>>>>>>>>> >>>>>>>>>>> -Remko >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On Sat, Jun 4, 2016 at 1:50 AM, Gary Gregory >>>>>>>>>>>> <garydgreg...@gmail.com> wrote: >>>>>>>>>>>>> On Fri, Jun 3, 2016 at 8:57 AM, Ralph Goers >>>>>>>>>>>>> <ralph.go...@dslextreme.com> wrote: >>>>>>>>>>>>> Are there any other fixes that have to go in? I am thinking I >>>>>>>>>>>>> will start the release tonight or tomorrow morning. >>>>>>>>>>>> >>>>>>>>>>>> Good to go from my POV. >>>>>>>>>>>> >>>>>>>>>>>> Gary >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Ralph >>>>>>>>>>>>> >>>>>>>>>>>>> > On Jun 1, 2016, at 2:57 PM, Ralph Goers >>>>>>>>>>>>> > <ralph.go...@dslextreme.com> wrote: >>>>>>>>>>>>> > >>>>>>>>>>>>> > I just fixed LOGJ2-1402. I would also like to modify >>>>>>>>>>>>> > RenameAction to use java.nio.file to rename and delete so that >>>>>>>>>>>>> > we can get better logging out of them. Ultimately, I want to >>>>>>>>>>>>> > address LOG4J2-1180 to have the rolling file appender write >>>>>>>>>>>>> > directly into the “rollover files” as this is apparently the >>>>>>>>>>>>> > only real fix for Windows. However, I don’t want to do that in >>>>>>>>>>>>> > a point release. >>>>>>>>>>>>> > >>>>>>>>>>>>> > LOG4J2-1180 was updated today and it seems the support for >>>>>>>>>>>>> > having Loggers stored by their message factory is not working >>>>>>>>>>>>> > correctly. Gary apparently is also experiencing this problem. >>>>>>>>>>>>> > >>>>>>>>>>>>> > I would like to see if we can fix these three items this week >>>>>>>>>>>>> > and do another release this weekend. If there are any other >>>>>>>>>>>>> > bugs that can be addressed by then I’m ok with that. >>>>>>>>>>>>> > >>>>>>>>>>>>> > Thoughts? >>>>>>>>>>>>> > >>>>>>>>>>>>> > Ralph >>>>>>>>>>>>> > >>>>>>>>>>>>> > --------------------------------------------------------------------- >>>>>>>>>>>>> > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org >>>>>>>>>>>>> > For additional commands, e-mail: >>>>>>>>>>>>> > log4j-dev-h...@logging.apache.org >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>>>> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org >>>>>>>>>>>>> For additional commands, e-mail: log4j-dev-h...@logging.apache.org >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>>>> Spring Batch in Action >>>>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>> JUnit in Action, Second Edition >>>>>>>> Spring Batch in Action >>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>> Home: http://garygregory.com/ >>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>> JUnit in Action, Second Edition >>>>>>> Spring Batch in Action >>>>>>> Blog: http://garygregory.wordpress.com >>>>>>> Home: http://garygregory.com/ >>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>>> Java Persistence with Hibernate, Second Edition >>>>> JUnit in Action, Second Edition >>>>> Spring Batch in Action >>>>> Blog: http://garygregory.wordpress.com >>>>> Home: http://garygregory.com/ >>>>> Tweet! http://twitter.com/GaryGregory >>>> >> >
