Should this: private int getMinCount(final Strategy strategy) { if (Strategy.DROP == strategy) { return 0; } else { // Strategy.RETAIN return 1; } }
be: private int getMinCount(final Strategy strategy) { return strategy.getMinCount(); } ? Seems more OO to me. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory