Yeah, some tests just do not use these values, some do. I just removed the ivar (and associated cruft) for the tests that do not use them.
Gary On Tue, Jun 28, 2016 at 4:50 PM, Remko Popma <[email protected]> wrote: > We are still testing the bz2 compression on rollover, aren't we? I saw > some commit fly by that removed a .bz2 or .gz (from a Rule if I remember > correctly). Comment was that it was unused. Don't have time to look at the > code now... > > Sent from my iPhone > > On 2016/06/29, at 3:34, Gary Gregory <[email protected]> wrote: > > I think all of the rolling tests should be fixed > like org.apache.logging.log4j.core.appender.rolling.RollingAppenderSizeTest > (which I actually did not finish cleaning up, it should not need to call > its own deleteDir() any longer). > > Gary > > On Tue, Jun 28, 2016 at 11:13 AM, Matt Sicker <[email protected]> wrote: > >> It's bz2 again. Should we just @Ignore this test or add an assumption >> that we're not on Jenkins? >> >> On 28 June 2016 at 12:07, Apache Jenkins Server < >> [email protected]> wrote: >> >>> See <https://builds.apache.org/job/Log4j%202.x/2071/changes> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> >> >> -- >> Matt Sicker <[email protected]> >> > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
