Jansi is for console logging so almost by definition not performance sensitive. I agree that making this garbage-free is not a priority. (I mean, if it were easy then fine but certainly no need to bend over backwards to achieve this).
Sent from my iPhone > On 2016/06/30, at 8:02, Gary Gregory <[email protected]> wrote: > >> On Wed, Jun 29, 2016 at 1:47 PM, Matt Sicker <[email protected]> wrote: >> Wouldn't it make sense to save it for 2.7? > > Sure, we could do it that way. I thought 2.6.2 might be OK since we have at > least one other new minor feature in there. > > I am looking for a code review of the method > MessagePatternConverter.format(LogEvent, StringBuilder): > > https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=blob;f=log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java;h=68fc25cb3de8155c6c2fafc0c9904c7b851467a9;hb=refs/heads/StyledMessage > > If you use ANSI, it is not GC-free, which is OK for now I claim. Going GC > would mean reworking a lot of JAnsi code I think. > > Gary > >> >>> On 29 June 2016 at 15:23, Gary Gregory <[email protected]> wrote: >>> Another neat feature I plan on doing is adding color to our extended stack >>> traces. >>> >>> Any thoughts on merging (or not) the StyledMessage branch to master? >>> >>> Gary >>> >>>> On Tue, Jun 28, 2016 at 8:46 AM, Gary Gregory <[email protected]> >>>> wrote: >>>> Thank you. >>>> >>>> FWIW, one of my goals is to be able to make pages of hex dumps easier to >>>> read on the console, with addresses, hex data, char data, and separators >>>> in different colors. For example, nicer than >>>> http://mynixworld.info/wp-content/uploads/2012/09/boot-loader-hexdump1.png >>>> >>>> Gary >>>> >>>>> On Tue, Jun 28, 2016 at 8:22 AM, Matt Sicker <[email protected]> wrote: >>>>> That is pretty cool and totally makes my use of clog look basic. >>>>> >>>>>> On 28 June 2016 at 09:37, Paul Benedict <[email protected]> wrote: >>>>>> That's very nice looking! >>>>>> >>>>>> Cheers, >>>>>> Paul >>>>>> >>>>>>> On Tue, Jun 28, 2016 at 1:03 AM, Gary Gregory <[email protected]> >>>>>>> wrote: >>>>>>> For fun: https://ibin.co/2mBev3ns9FJz.png >>>>>>> >>>>>>> Gary >>>>>>> >>>>>>>> On Wed, Jun 15, 2016 at 10:50 PM, Gary Gregory >>>>>>>> <[email protected]> wrote: >>>>>>>> Hi All, >>>>>>>> >>>>>>>> See color messages in Maven 3.4.0-SNAPSHOT made me think of the >>>>>>>> following. >>>>>>>> >>>>>>>> Right now, with Jansi on the CP, I can say: >>>>>>>> >>>>>>>> import static org.fusesource.jansi.Ansi.*; >>>>>>>> import static org.fusesource.jansi.Ansi.Color.*; >>>>>>>> ... >>>>>>>> logger.info(ansi().fg(RED).a("Hello").fg(CYAN).a(" World").reset()); >>>>>>>> >>>>>>>> and the right thing happens on the console. >>>>>>>> >>>>>>>> If I also have a file appender, I get the escape codes in the file, >>>>>>>> which I do not think most people would want. >>>>>>>> >>>>>>>> The question is, how can we make it simple for users to have their >>>>>>>> cake and eat it too? >>>>>>>> >>>>>>>> With a special Message implementation? >>>>>>>> >>>>>>>> Thoughts? >>>>>>>> >>>>>>>> Thank you, >>>>>>>> Gary >>>>>>>> -- >>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>> JUnit in Action, Second Edition >>>>>>>> Spring Batch in Action >>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>> Home: http://garygregory.com/ >>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> E-Mail: [email protected] | [email protected] >>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>> JUnit in Action, Second Edition >>>>>>> Spring Batch in Action >>>>>>> Blog: http://garygregory.wordpress.com >>>>>>> Home: http://garygregory.com/ >>>>>>> Tweet! http://twitter.com/GaryGregory >>>>> >>>>> >>>>> >>>>> -- >>>>> Matt Sicker <[email protected]> >>>> >>>> >>>> >>>> -- >>>> E-Mail: [email protected] | [email protected] >>>> Java Persistence with Hibernate, Second Edition >>>> JUnit in Action, Second Edition >>>> Spring Batch in Action >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>> >>> >>> >>> -- >>> E-Mail: [email protected] | [email protected] >>> Java Persistence with Hibernate, Second Edition >>> JUnit in Action, Second Edition >>> Spring Batch in Action >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >> >> >> >> -- >> Matt Sicker <[email protected]> > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
