[ https://issues.apache.org/jira/browse/LOG4J2-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390977#comment-15390977 ]
ASF GitHub Bot commented on LOG4J2-1341: ---------------------------------------- Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/35 PR looks good at first glance. Unit test would be nice. Can you link this pull request to another Jira? LOG4J2-1341 is the ticket for GC-free pattern converters which is not related to FixedDateFormat. Feel free to create a new Jira ticket if no matching one exists. > (GC) Avoid allocating temporary objects in Pattern Converters for > PatternLayout > ------------------------------------------------------------------------------- > > Key: LOG4J2-1341 > URL: https://issues.apache.org/jira/browse/LOG4J2-1341 > Project: Log4j 2 > Issue Type: Improvement > Components: Pattern Converters > Affects Versions: 2.5 > Reporter: Remko Popma > Fix For: 2.7 > > > *To do* > The following pattern converters can be modified to avoid creating temporary > objects in their {{format}} method: > * AbstractStyleNameConverter > * EncodingPatternConverter > * EqualsIgnoreCaseReplacementConverter > * EqualsReplacementConverter > * FullLocationPatternConverter > * HighlightConverter > * IntegerPatternConverter > * MarkerPatternConverter > * MaxLengthConverter > * RelativeTimePatternConverter > * SequenceNumberPatternConverter > * StyleConverter > *Investigate* > The following pattern converters may be difficult to modify since they rely > on JDK components that create temporary objects: > * ExtendedThrowablePatternConverter > * MapPatternConverter > * MdcPatternConverter > * NdcPatternConverter > * RegexReplacementConverter > * RootThrowablePatternConverter > * ThrowablePatternConverter > * UuidPatternConverter > * VariablesNotEmptyReplacementConverter > *Done* > The following pattern converters already do not allocate temporary objects in > their format method: > * ClassNamePatternConverter > * DatePatternConverter > * FileLocationPatternConverter > * LevelPatternConverter > * LineLocationPatternConverter > * LineSeparatorPatternConverter > * LiteralPatternConverter (unless literal contains '${') > * LoggerPatternConverter > * MarkerSimpleNamePatternConverter > * MessagePatternConverter > * MethodLocationPatternConverter > * NamePatternConverter > * NanoTimePatternConverter > * ThreadIdPatternConverter > * ThreadNamePatternConverter > * ThreadPriorityPatternConverter -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org