[
https://issues.apache.org/jira/browse/LOG4J2-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427710#comment-15427710
]
ASF GitHub Bot commented on LOG4J2-1511:
----------------------------------------
GitHub user surukuntu opened a pull request:
https://github.com/apache/logging-log4j2/pull/40
LOG4J2-1511-fix-dynamic-threshold-filter-to-work-with-params
…ual arguments instead of varargs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/surukuntu/logging-log4j2
LOG4J2-1511-fix-dynamic-threshold-filter-to-work-with-params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit c36aea89f10c48ade811827587d1b7b94a75079f
Author: srikanth surukuntu <[email protected]>
Date: 2016-08-19T06:49:13Z
Ensure dynamicthresholdFilter works when params are passed as individual
arguments instead of varargs
----
> DynamicThresholdFilter filters incorrectly when params are passed as
> individual arguments instead of varargs
> ------------------------------------------------------------------------------------------------------------
>
> Key: LOG4J2-1511
> URL: https://issues.apache.org/jira/browse/LOG4J2-1511
> Project: Log4j 2
> Issue Type: Bug
> Affects Versions: 2.6.2
> Reporter: srikanth surukuntu
>
> The below test should summarize the issue.
> {code}
> package org.apache.logging.log4j.core.filter;
> import static org.junit.Assert.assertSame;
> import static org.junit.Assert.assertTrue;
> import org.apache.logging.log4j.Level;
> import org.apache.logging.log4j.ThreadContext;
> import org.apache.logging.log4j.core.Filter;
> import org.apache.logging.log4j.core.LoggerContext;
> import org.apache.logging.log4j.core.util.KeyValuePair;
> import org.apache.logging.log4j.status.StatusLogger;
> import org.junit.After;
> import org.junit.Test;
> /**
> *
> */
> public class DynamicThresholdFilterTest {
> @After
> public void cleanup() {
> final LoggerContext ctx = LoggerContext.getContext(false);
> ctx.reconfigure();
> StatusLogger.getLogger().reset();
> }
> @Test
> public void testFilter() {
> ThreadContext.put("userid", "testuser");
> ThreadContext.put("organization", "apache");
> final KeyValuePair[] pairs = new KeyValuePair[] {
> new KeyValuePair("testuser", "DEBUG"),
> new KeyValuePair("JohnDoe", "warn") };
> final DynamicThresholdFilter filter =
> DynamicThresholdFilter.createFilter("userid", pairs, Level.ERROR,
> Filter.Result.ACCEPT, Filter.Result.NEUTRAL);
> filter.start();
> assertTrue(filter.isStarted());
> Object [] replacements = {"one", "two", "three"};
> assertSame(Filter.Result.ACCEPT, filter.filter(null, Level.DEBUG,
> null, "some test message", replacements)); // Works
> assertSame(Filter.Result.ACCEPT, filter.filter(null, Level.DEBUG,
> null, "some test message", "one", "two", "three")); // Doesn't work but it
> should
> ThreadContext.clearMap();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
