[jira] [Comment Edited] (LOG4J2-1531) Change attribute and component values from String to Object

[JIRA]

    [ 
https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428754#comment-15428754
 ] 

Mikael Ståldal edited comment on LOG4J2-1531 at 8/19/16 8:18 PM:
-----------------------------------------------------------------

I'm not sure it's wise to add {{addArgument(String, Object)}} to 
{{ComponentBuilder}}.

What about instead add something like this:

{code}
    interface FilterFunction {
        boolean apply(Object msg);
    }
    
    FilterComponentBuilder newFilter(FilterFunction fn, Filter.Result onMatch, 
Filter.Result onMisMatch);
{code}

Which would allow you to do this even more simple:

{code}
    ConfigurationBuilder.FilterFunction fn = new 
ConfigurationBuilder.FilterFunction() {
        @Override
        public boolean apply(Object msg) {
            return /* logic here */;
        }
    };
        
    builder.add(builder.newFilter(fn, Filter.Result.DENY, 
Filter.Result.NEUTRAL));
{code}


was (Author: mikaelstaldal):
I'm not sure it's wise to add {{addArgument(String, Object)}} to 
{{ComponentBuilder}}.

What about instead add something like this:

{{code}}
    interface FilterFunction {
        boolean apply(Object msg);
    }
    
    FilterComponentBuilder newFilter(FilterFunction fn, Filter.Result onMatch, 
Filter.Result onMisMatch);
{{code}}

Which would allow you to do this even more simple:

{{code}}
    ConfigurationBuilder.FilterFunction fn = new 
ConfigurationBuilder.FilterFunction() {
        @Override
        public boolean apply(Object msg) {
            return /* logic here */;
        }
    };
        
    builder.add(builder.newFilter(fn, Filter.Result.DENY, 
Filter.Result.NEUTRAL));
{{code}}

> Change attribute and component values from String to Object
> -----------------------------------------------------------
>
>                 Key: LOG4J2-1531
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1531
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.6.2
>            Reporter: Roger Kapsi
>         Attachments: log4j2-1531-1.0.patch
>
>
> I was looking into creating a ConfigurationFactory/Builder that is backed by 
> a Clojure DSL. It works rather beautifully until I tried to create a filter 
> that is backed by a Clojure function. There is literally  no way to pass 
> arbitrary objects into a PluginFactory. All component values and attributes 
> are assumed to be Strings.
> {code:java}
> (configuration
>   (appender "stdout" "CONSOLE"
>     (layout "PatternLayout"
>       (attribute "pattern" "%d [%t] %-5level: %msg%n"))
>     (filter "ClojureFilter"
>       ;; This LoC doesn't work: addAttribute(key, value)
>       ;; will store the toString() of the value. Bummer.
>       ;; I'd the so easy and beautiful if it didn't.
>       (attribute "fn" (fn [logger & more] (println logger)))))
>   
>   (logger "TestLogger" Level/INFO
>     (appender-ref "rolling")
>     (attribute "additivity" false))
>   (root-logger Level/DEBUG 
>     (appender-ref "rolling")))
> {code}
> {code:java}
> @Plugin(name = "ClojureFilter", category = Node.CATEGORY, elementType = 
> Filter.ELEMENT_TYPE, printObject = true)
> class ClojureFilter extends AbstractFilter {
>   @PluginFactory
>   public static ClojureFilter createFilter(
>       @PluginAttribute("fn") IFn fn, ...) {
>      return new ClojureFilter(fn, ...);
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org