[
https://issues.apache.org/jira/browse/LOG4J2-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456666#comment-15456666
]
Ralph Goers commented on LOG4J2-1557:
-------------------------------------
Not that adding a builder is wrong, but this is another case of creating an
issue, fixing it, and committing it before anyone realizes there is a "problem".
If we had an epic issue listing all the components that need builders, and we
all had agreed to do it, this would be fine. If you have some compelling need
to add more parameters then this would be fine. But once again you didn't
document why any of this is necessary or if you are just doing this because you
have nothing better to do.
> Add a Builder for the SocketAppender (deprecates factory method)
> ----------------------------------------------------------------
>
> Key: LOG4J2-1557
> URL: https://issues.apache.org/jira/browse/LOG4J2-1557
> Project: Log4j 2
> Issue Type: Improvement
> Components: Appenders
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Fix For: 2.7
>
>
> Add a Builder for the SocketAppender (deprecates the factory method).
> Deprecated:
> -
> org.apache.logging.log4j.core.appender.SocketAppender.createAppender(String,
> int, Protocol, SslConfiguration, int, int, boolean, String, boolean, boolean,
> Layout<? extends Serializable>, Filter, boolean, Configuration)
> -
> org.apache.logging.log4j.core.appender.SocketAppender.createAppender(String,
> String, String, SslConfiguration, int, String, String, String, String,
> String, Layout<? extends Serializable>, Filter, String, Configuration)
> When should we deprecate these?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
