As long as the stacktrace still shows what happened before the rethrow, I'm happy. :-)
Sent from my iPhone > On 2016/09/02, at 9:44, Gary Gregory <[email protected]> wrote: > > It is better than before because there one less "caused by" level. > > Gary > > >> On Sep 1, 2016 8:28 PM, "Remko Popma" <[email protected]> wrote: >> Does that preserve the original stacktrace? >> >> Sent from my iPhone >> >>> On 2016/09/02, at 6:06, Gary Gregory <[email protected]> wrote: >>> >>>> On Wed, Aug 31, 2016 at 7:22 PM, Matt Sicker <[email protected]> wrote: >>>> If it's just to rethrow a checked exception, it should use >>>> Throwables.rethrow(Throwable t). No exception wrapping is done in that >>>> method anymore thanks to an abuse of generics I found a couple months ago, >>>> so the stacktrace looks better. >>> >>> Done in Git master. >>> >>> Gary >>> >>>> >>>>> On 31 August 2016 at 11:29, Gary Gregory <[email protected]> wrote: >>>>> We've got a few of these... not good. Surely there is a better exception >>>>> checked or not we can use. >>>>> >>>>> Gary >>>>> >>>>> -- >>>>> E-Mail: [email protected] | [email protected] >>>>> Java Persistence with Hibernate, Second Edition >>>>> JUnit in Action, Second Edition >>>>> Spring Batch in Action >>>>> Blog: http://garygregory.wordpress.com >>>>> Home: http://garygregory.com/ >>>>> Tweet! http://twitter.com/GaryGregory >>>> >>>> >>>> >>>> -- >>>> Matt Sicker <[email protected]> >>> >>> >>> >>> -- >>> E-Mail: [email protected] | [email protected] >>> Java Persistence with Hibernate, Second Edition >>> JUnit in Action, Second Edition >>> Spring Batch in Action >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory
