I don’t think moving it is a good idea. The Status Logger is initialized as soon as it possibly can be, which is after we have read the attributes for the Configuration element. If the call is moved to the initialize method then no status logging will occur while the configuration is processed.
Ralph > On Sep 12, 2016, at 11:25 AM, Matt Sicker <boa...@gmail.com> wrote: > > Anything to reduce duplication of code is great! The Configuration classes > have quite a bit of duplication right now and are prime candidates for some > refactoring love. > > On 28 August 2016 at 07:38, Mikael Ståldal <mikael.stal...@magine.com > <mailto:mikael.stal...@magine.com>> wrote: > The method StatusConfiguration.initialize() is invoked from > ConfigurationBuilder.build() and the constructors of XmlConfiguration, > JsonConfiguration and CompositeConfiguration. > > Would it make sense if this was instead done in one place, in > Configuration.initialize()? That would make the lifecycle of the > configuration more consistent, first build it and then initialize it. > > > > > -- > Matt Sicker <boa...@gmail.com <mailto:boa...@gmail.com>>
