Who knows this code best to see if this patch makes sense? Gary ---------- Forwarded message ---------- From: challarao <notificati...@github.com> Date: Fri, Aug 26, 2016 at 3:48 PM Subject: [apache/logging-log4j2] Documentation bug for purgeAscending method. (#41) To: apache/logging-log4j2 <logging-log...@noreply.github.com>
For "@param <https://github.com/param> highIndex Log file associated with high index will be deleted if needed. " That is incorrect it seems, that applies to purgeDescending. That message should be under "@param <https://github.com/param> lowIndex with the message Log file associated with low index will be deleted if needed. " Because purgeAscending deletes the one with the low index if required, if I'm not wrong. ------------------------------ You can view, comment on, or merge this pull request online at: https://github.com/apache/logging-log4j2/pull/41 Commit Summary - Documentation bug for purgeAscending method. File Changes - *M* log4j-core/src/main/java/org/apache/logging/log4j/core/ appender/rolling/DefaultRolloverStrategy.java <https://github.com/apache/logging-log4j2/pull/41/files#diff-0> (4) Patch Links: - https://github.com/apache/logging-log4j2/pull/41.patch - https://github.com/apache/logging-log4j2/pull/41.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/apache/logging-log4j2/pull/41>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIfN85RwiKA-40UN0wItGq-bJ_Q5dvvks5qj21QgaJpZM4Juh31> . -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
