[
https://issues.apache.org/jira/browse/LOG4J2-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500080#comment-15500080
]
Remko Popma edited comment on LOG4J2-1590 at 9/18/16 3:07 AM:
--------------------------------------------------------------
TODO
Add test and document which of these are currently garbagefree:
* BurstFilter (allocates, non-trivial to change)
* CompositeFilter (adding & removing elements produces garbage for thread
safety, no allocation in steady state)
* DynamicThresholdFilter (garbage free)
* LevelRangeFilter (can be garbage free after overriding unrolled vararg
methods)
* MapFilter (creates iterator for each event to loop over the map. Easy to
change by constructing MapFilter with an ArraContextData instead of a Map, and
overriding unrolled vararg methods)
* MarkerFilter (can be garbage free after overriding unrolled vararg methods)
* RegexFilter (not garbagefree due to JDK regex library)
* ScriptFilter (not garbagefree: creates new Binding object for each event)
* StructuredDataFilter
* ThreadContextMapFilter
* ThresholdFilter
was (Author: rem...@yahoo.com):
TODO
Add test and document which of these are currently garbagefree:
* BurstFilter (allocates, non-trivial to change)
* CompositeFilter (adding & removing elements produces garbage for thread
safety, no allocation in steady state)
* DynamicThresholdFilter (garbage free)
* LevelRangeFilter (can be garbage free after overriding unrolled vararg
methods)
* MapFilter (creates iterator for each event to loop over the map. Easy to
change by constructing MapFilter with an ArraContextData instead of a Map, and
overriding unrolled vararg methods)
* MarkerFilter (can be garbage free after overriding unrolled vararg methods)
* RegexFilter
* ScriptFilter
* StructuredDataFilter
* ThreadContextMapFilter
* ThresholdFilter
> AbstractFilter should call vararg method from methods with unrolled parameters
> ------------------------------------------------------------------------------
>
> Key: LOG4J2-1590
> URL: https://issues.apache.org/jira/browse/LOG4J2-1590
> Project: Log4j 2
> Issue Type: Bug
> Components: Filters
> Affects Versions: 2.6.2
> Reporter: Remko Popma
> Assignee: Remko Popma
> Fix For: 2.7
>
>
> AbstractFilter should call vararg method from methods with unrolled
> parameters.
> This would prevent issues like LOG4J2-1511 in all filter implementations that
> extend AbstractFilter. Subclasses can override the unrolled vararg methods to
> provide a garbage-free implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
