I see a Findbugs error in:
org.apache.logging.log4j.core.impl.Log4jLogEvent.hashCode()
for:
result = 31 * result + (threadPriority ^ (threadPriority >>> 32));
"The code performs shift of a 32 bit int by a constant amount outside the
range -31..31. The effect of this is to use the lower 5 bits of the integer
value to decide how much to shift by (e.g., shifting by 40 bits is the same
as shifting by 8 bits, and shifting by 32 bits is the same as shifting by
zero bits). This probably isn't what was expected, and it is at least
confusing."
Thoughts?
Gary
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
