Gary Gregory created LOG4J2-1603: ------------------------------------ Summary: Redo hashCode() and equals() methods in org.apache.logging.log4j.core.net.ssl classes. Key: LOG4J2-1603 URL: https://issues.apache.org/jira/browse/LOG4J2-1603 Project: Log4j 2 Issue Type: Bug Components: Core Affects Versions: 2.6.2 Reporter: Gary Gregory Assignee: Gary Gregory Fix For: 2.7
We have a few FindBugs warnings about {{hashCode()}} and {{equals(Object)}} methods in the package {{org.apache.logging.log4j.core.net.ssl}} classes. The first problem is that not all classes implement these method where some of the code expects it to like an {{equals()}} method calling another {{equals()}} method but there is not one and the behavior of {{Object.equals()}} kicks in. This change make it obvious where there are still issues: the behavior described above will only happen when the code path ends up in a JRE class which itself depends on {{Object.equals()}}, so you still get a FindBugs warning about that but it is no longer a warning about a class in our code. We can revisit how to best implement {{equals()}} for those classes later. It is possible that the warning is a false positive since the JRE could be using a subclass of the class FindBugs complains about. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org