It may be more effective to add a "note to implementors" to that effect in the 
javadoc. 
Programmers are more likely to follow your advice if they know the reason 
behind it.

Sent from my iPhone

> On 2016/09/21, at 8:29, ggreg...@apache.org wrote:
> 
> Repository: logging-log4j2
> Updated Branches:
>  refs/heads/master 08a529fbb -> 436416b99
> 
> 
> Add equals() and hashCode() since Log4jLogEvent's equals() and
> hashCode() depends on them, all implementors should implement these
> methods.
> 
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/436416b9
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/436416b9
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/436416b9
> 
> Branch: refs/heads/master
> Commit: 436416b990fe7f405cc4b57aa5ea2dae1ea04518
> Parents: 08a529f
> Author: Gary Gregory <ggreg...@apache.org>
> Authored: Tue Sep 20 16:29:18 2016 -0700
> Committer: Gary Gregory <ggreg...@apache.org>
> Committed: Tue Sep 20 16:29:18 2016 -0700
> 
> ----------------------------------------------------------------------
> .../logging/log4j/spi/MutableContextData.java     | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/436416b9/log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableContextData.java
> ----------------------------------------------------------------------
> diff --git 
> a/log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableContextData.java
>  
> b/log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableContextData.java
> index 96251ef..346ea35 100644
> --- 
> a/log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableContextData.java
> +++ 
> b/log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableContextData.java
> @@ -80,4 +80,22 @@ public interface MutableContextData extends ContextData {
>      * @return  {@code true} if this object has been {@linkplain #freeze() 
> frozen}, {@code false} otherwise
>      */
>     boolean isFrozen();
> +
> +    /**
> +     * Returns a hash code value for the object.
> +     * @return a hash code value for this object.
> +     */
> +    @Override
> +    int hashCode();
> +
> +    /**
> +     * Indicates whether some other object is "equal to" this one.
> +     * 
> +     * @param obj
> +     *            the reference object with which to compare.
> +     * @return {@code true} if this object is the same as the obj argument; 
> {@code false} otherwise.
> +     * @see #hashCode()
> +     */
> +    @Override
> +    boolean equals(final Object obj);
> }
> \ No newline at end of file
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to