On Thu, Oct 27, 2016 at 1:12 AM, Mikael Ståldal <mikael.stal...@magine.com>
wrote:
> Maybe logger.warn(SQL_WARN, "", sqlWarning);
>
Yeah, I am doing something like that but it does feel ugly:
private static SQLWarning log(SQLWarning sqlWarning) {
// (1) Log a plain warning but not the SQLWarning itself which is
an exception and may confuse users
LOGGER.warn(DvMarkers.SQL_WARNING, sqlWarning.toString());
final Marker marker =
MarkerManager.getMarker(sqlWarning.getClass().getName()).setParents(DvMarkers.SQL_WARNING_EX);
// (2) Log the full details of the SQLWarning as a separate event
and with an exception specific marker.
LOGGER.warn(marker, Strings.EMPTY, sqlWarning);
return sqlWarning;
}
I do not like logging two events but I do not see how to achieve what I
really want without extending Log4j...
Gary
>
> On Thu, Oct 27, 2016 at 1:24 AM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
>
>> On Wed, Oct 26, 2016 at 4:02 PM, Remko Popma <remko.po...@gmail.com>
>> wrote:
>>
>>> I would split them up and use a marker:
>>>
>>> logger.warn(sqlWarning.getMessage());
>>> logger.warn(SQL_WARN_EX, sqlWarning);
>>>
>>
>> I tried that but the (Marker, Object) API logs the toString() of the
>> exception, not the exception.
>>
>> It seems to me we need to add a (Marker, Throwable) set of APIs to Logger.
>>
>> Gary
>>
>>
>>>
>>> Then use a marker filter in configuration to exclude the stack traces
>>> with the marker.
>>>
>>> Sent from my iPhone
>>>
>>> On 27 Oct 2016, at 2:41, Gary Gregory <garydgreg...@gmail.com> wrote:
>>>
>>> I have the following use cases that I am pondering on how to best handle:
>>>
>>> I log exceptions like a JDBC SQLWarning (a subclass of Exception):
>>>
>>> logger.warn(sqlWarning.getMessage(). sqlWarning);
>>>
>>> and I want to be able to tell users: "do this to hide this stack trace
>>> but you'll still see the message, note that all other exception are logged
>>> normally".
>>>
>>> How would you do that?
>>>
>>> Invent:
>>> %exception{skipStackTrace=java.sql.SQLWarning}
>>> or
>>> %exception{messageOnly=java.sql.SQLWarning}
>>>
>>> Thoughts?
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>
>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
>>> JUnit in Action, Second Edition
>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>>
>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
>>> Spring Batch in Action
>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>
>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
>> JUnit in Action, Second Edition
>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>
>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
>> Spring Batch in Action
>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> [image: MagineTV]
>
> *Mikael Ståldal*
> Senior software developer
>
> *Magine TV*
> mikael.stal...@magine.com
> Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com
>
> Privileged and/or Confidential Information may be contained in this
> message. If you are not the addressee indicated in this message
> (or responsible for delivery of the message to such a person), you may not
> copy or deliver this message to anyone. In such case,
> you should destroy this message and kindly notify the sender by reply
> email.
>
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
