I agree. Using defaults should make it a bit more concise.
On 11 November 2016 at 14:20, Gary Gregory <garydgreg...@gmail.com> wrote:
> In code like:
>
> @PluginFactory
> public static ScriptPatternSelector
> createSelector(@PluginElement("Script")
> final AbstractScript script,
>
> @PluginElement("PatternMatch") final PatternMatch[] properties,
>
> @PluginAttribute("defaultPattern")
> String defaultPattern,
>
> @PluginAttribute(value = "alwaysWriteExceptions", defaultBoolean = true)
> final boolean alwaysWriteExceptions,
>
> @PluginAttribute(value = "noConsoleNoAnsi", defaultBoolean = false) final
> boolean noConsoleNoAnsi,
>
> @PluginConfiguration final Configuration config) {
>
> Do we really need to say:
>
> defaultBoolean = false
>
> ?
>
> Since we do not that with ivars and we know the default value for booleans
> is false.
>
> My proposal is to remove redundancies like this one.
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Matt Sicker <boa...@gmail.com>
