[ 
https://issues.apache.org/jira/browse/LOG4J2-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15659849#comment-15659849
 ] 

Raman Gupta edited comment on LOG4J2-1685 at 11/12/16 3:53 PM:
---------------------------------------------------------------

Ok [~garydgregory] and [~mikaelstaldal] : I have reworked the patch on the 
latest master with builders, incorporating the earlier feedback from Mikael as 
well. Here is the new patch series:

https://github.com/apache/logging-log4j2/compare/apache:master...rocketraman:LOG4J2-1685.patch

I have made a few minor modifications in the first two commits which are more 
related to the earlier builder-migration work by [~garydgregory] rather than 
this issue. If I am mistaken in my understanding let me know and I can drop 
these two commits.


was (Author: rocketraman):
Ok [~garydgregory] and [~mikaelstaldal] : I have reworked the patch on the 
latest master with builders, incorporating the earlier feedback from Mikael as 
well. Here is the new patch series:

https://github.com/apache/logging-log4j2/compare/apache:master...rocketraman:LOG4J2-1685.patch

I have made a few minor modifications in the first two commits which are more 
related to the earlier builder-migration work by [~garydgregory] rather than 
this patch. If I am mistaken in my understanding let me know and I can drop 
these two commits.

> Single property to disable all color output
> -------------------------------------------
>
>                 Key: LOG4J2-1685
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1685
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Appenders
>    Affects Versions: 2.7
>            Reporter: Raman Gupta
>            Assignee: Mikael Ståldal
>            Priority: Minor
>
> I am deploying an app to a Windows server. The app will write logs to 
> standard output which will then be captured by some wrapper process.
> My default configuration contains ansi escapes for color, because they are 
> nice for every situation except this one.
> It would be nice if there was a simple way to disable all ansi output via a 
> system property and/or environment variable e.g.
> `-Dlog4j.ansi.enabled=false`
> This would operate similarly to the Spring Boot `spring.output.ansi.enabled` 
> property 
> (http://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-logging.html).
> In Spring Boot I believe this is handled by using conditionals in their 
> logback configuration (which would be super-nice in log4j also). With 
> conditional layout I could very easily do this myself by specifying two 
> different Pattern layouts in my config file, one with color and one without, 
> conditional on some system property or env var I define.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to