[
https://issues.apache.org/jira/browse/LOG4J2-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Christiansen updated LOG4J2-1687:
----------------------------------------
Attachment: LOG4J2-1687.patch
Hi [~garydgregory], I've attached a possible patch with test. Unfortunately I
couldn't get a meaningful test in place for ThrowableProxy since I was unable
to get a {{null}} response for {{class.getClassLoader}} even with Mockito or
cglib. Not saying it's not possible, but there are some restrictions on
reflection and final fields that was in the way for me. I did not go the path
of changing the runtime environment, which could be an avenue to get it under
test.
Since it's a simple refactoring, I've simply moved the check out in the
{{LoaderUtil}} as per [~jvz] recommendation and put the method it under test.
> NPE in ThrowableProxy when resolving stack
> ------------------------------------------
>
> Key: LOG4J2-1687
> URL: https://issues.apache.org/jira/browse/LOG4J2-1687
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.7
> Environment: - java version "1.7.0_80" ,Java(TM) SE Runtime
> Environment (build 1.7.0_80-b15), Java HotSpot(TM) 64-Bit Server VM (build
> 24.80-b11, mixed mode)
> - Jboss EAP 5.2.0-EAP
> Reporter: Robert Christiansen
> Labels: easyfix
> Attachments: LOG4J2-1687.patch, error.log, patch.diff
>
>
> NPE when logging in Java EE/OSGi environment.
> In some cases the ClassLoader (
> https://docs.oracle.com/javase/7/docs/api/java/lang/Class.html#getClassLoader()
> ) will be null for a Class.
> With the changes introduced in
> https://issues.apache.org/jira/browse/LOG4J2-1457 logging with %xEx can cause
> a NullPointerExeception when trying to resolve the stack.
> Since it's not a common occurrence in most environments I suggest the
> ThrowableProxy swallow the NPE in the same way it swallows SecurityExeception
> and other classloading exceptions to avoid extra branching for all
> environments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
