It doesn't feel right to put it in AbstractStringLayout.Builder since it does not make sense for all AbstractStringLayout:s.
It doesn't make sense for PatternLayout. (BTW, why doesn't PatternLayout.Builder extend AbstractStringLayout.Builder?) I would prefer another abstract class in between if we want to generalize this. On Jan 6, 2017 12:16 AM, "Matt Sicker" <boa...@gmail.com> wrote: > Can some sort of generic plugin similar to the ColumnMapping one I just > added be used here? Allow layouts within markup layouts. Seems kind of > meta, so it might require some more design. > > On 5 January 2017 at 17:10, Remko Popma <remko.po...@gmail.com> wrote: > >> There is an outstanding request for the JSON layout to show a formatted >> timestamp instead of (or in addition to) the current millis since epoch >> long. >> >> Could this AdditionalFields feature be used for that? >> >> Sent from my iPhone >> >> On Jan 6, 2017, at 7:40, Gary Gregory <garydgreg...@gmail.com> wrote: >> >> - HTML could, JSON could, XML could, YAML could (these are all pretty >> open ended) >> >> - Then I can recall if Syslog has such an allowance, I recall someone >> asking about that, perhaps in the message itself. >> >> - Does seem to make sense for CSV for example. >> >> Gary >> >> On Thu, Jan 5, 2017 at 2:34 PM, Remko Popma <remko.po...@gmail.com> >> wrote: >> >>> Which Layouts actually support additional fields? I wouldn't pull it up >>> until there's a need. >>> >>> Sent from my iPhone >>> >>> On Jan 6, 2017, at 4:08, Gary Gregory <garydgreg...@gmail.com> wrote: >>> >>> I think we should pull up org.apache.logging.log4j.co >>> re.layout.GelfLayout.Builder.additionalFields to the superclass so it >>> can be used in any layout (that allows for extra fields). >>> >>> Thoughts? >>> >>> Gary >>> >>> -- >>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>> Java Persistence with Hibernate, Second Edition >>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> >>> >>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> >>> JUnit in Action, Second Edition >>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> >>> >>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> >>> Spring Batch in Action >>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> >>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >>> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition >> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> >> >> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> >> JUnit in Action, Second Edition >> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> >> >> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> >> Spring Batch in Action >> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> >> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> >> > > > -- > Matt Sicker <boa...@gmail.com> >
