The new test failure (can't open zip) looks like a one-off...
Sent from my iPhone
> On Feb 15, 2017, at 9:58, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> On Tue, Feb 14, 2017 at 3:22 PM, Apache <ralph.go...@dslextreme.com> wrote:
>> What problem before what?
>>
>> RollingAppenderSizeTest was failing because I was manually trying to delete
>> files instead of letting the Rule do it.
>
> My mistake. I did not know that the issue was as simple as that.
>
> Gary
>
>>
>> Ralph
>>
>>> On Feb 14, 2017, at 2:56 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>>>
>>> Was the problem before that threads where not finishing normally on test
>>> completion? Could this be the same kind of issue?
>>>
>>> Gary
>>>
>>>> On Tue, Feb 14, 2017 at 1:28 PM, Apache <ralph.go...@dslextreme.com> wrote:
>>>> I got a Windows 10 VM installed and was able to reproduce the problem and
>>>> fix it. However, now the build is failing with
>>>>
>>>> Failed tests:
>>>>
>>>> GcFreeAsynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:34
>>>> Error opening zip file or JAR manifest missing :
>>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-allocation-instrumenter\java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar
>>>> expected:<[FATAL o.a.l.l.c.GcFreeAsynchronousLoggingTest [main] value1
>>>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>>>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>>>> missing :
>>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-allocation-instrumenter\java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar]>
>>>>
>>>> GcFreeMixedSyncAyncLoggingTest.testNoAllocationDuringSteadyStateLogging:30
>>>> Error opening zip file or JAR manifest missing :
>>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-allocation-instrumenter\java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar
>>>> expected:<[FATAL o.a.l.l.c.GcFreeMixedSyncAyncLoggingTest [main] value1
>>>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>>>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>>>> missing :
>>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-allocation-instrumenter\java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar]>
>>>> GcFreeSynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:30
>>>> Error opening zip file or JAR manifest missing :
>>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-allocation-instrumenter\java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar
>>>> expected:<[FATAL o.a.l.l.c.GcFreeSynchronousLoggingTest [main] value1
>>>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>>>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>>>> missing :
>>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-allocation-instrumenter\java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar]>
>>>>
>>>> Ralph
>>>>
>>>>> On Feb 13, 2017, at 12:13 PM, Apache <ralph.go...@dslextreme.com> wrote:
>>>>>
>>>>> No. I plan to figure out why it is breaking.
>>>>>
>>>>> Ralph
>>>>>
>>>>>> On Feb 13, 2017, at 11:02 AM, Gary Gregory <garydgreg...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>> My hope was that Ralph would revert his commit that broke the build on
>>>>>> Windows.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>> On Mon, Feb 13, 2017 at 10:01 AM, Gary Gregory <garydgreg...@gmail.com>
>>>>>>> wrote:
>>>>>>> Maven just works as in on Windows. I have the Maven bin folder on my
>>>>>>> PATH, that's it, it contains mvn.cmd.
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>>> On Mon, Feb 13, 2017 at 9:45 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>>> Well, that's step one! My only Windows computer is for videogames, so
>>>>>>>> I'm not really experienced with development in such an environment
>>>>>>>> these days. If you can figure out how to get the mvnw.cmd script to
>>>>>>>> work in Windows, that'd be great.
>>>>>>>>
>>>>>>>>> On 13 February 2017 at 11:26, Gary Gregory <garydgreg...@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>> Thank you for setting that up Matt. I can see the same failures on
>>>>>>>>> https://builds.apache.org/job/Log4jWindows/ as I do locally.
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>> On Sun, Feb 12, 2017 at 11:11 PM, Matt Sicker <boa...@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>> Also, using a similar multi-config Jenkins job, we can set up JDK 7,
>>>>>>>>>> 8, and 9pre Linux builds as well.
>>>>>>>>>>
>>>>>>>>>>> On 13 February 2017 at 01:08, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>>>>>> Sorry for the deluge of build emails, forgot to disable that.
>>>>>>>>>>>
>>>>>>>>>>> Anyways, I got the build running for Windows:
>>>>>>>>>>> <https://builds.apache.org/job/Log4jWindows/>. I have it set to run
>>>>>>>>>>> daily for now as there's only two windows VMs and I don't want to
>>>>>>>>>>> hog them.
>>>>>>>>>>>
>>>>>>>>>>> Ok, I have no idea why the mvnw script isn't running on there
>>>>>>>>>>> properly, but I did manage to find the proper incantation to run
>>>>>>>>>>> mvn on that Windows VM. This project has examples:
>>>>>>>>>>> <https://builds.apache.org/job/infra-test-maven-windows/>.
>>>>>>>>>>>
>>>>>>>>>>>> On 12 February 2017 at 23:10, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>>>>>>> Well, I've got some sort of thing working across a rather
>>>>>>>>>>>> unintentionally wide variety of environments. Turns out getting
>>>>>>>>>>>> the Windows builds to work might be simplified by including a
>>>>>>>>>>>> maven wrapper because I don't really know how these VMs are set up.
>>>>>>>>>>>>
>>>>>>>>>>>>> On 12 February 2017 at 22:52, Matt Sicker <boa...@gmail.com>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>> JAVA_HOME not defined correctly on almost all the environments.
>>>>>>>>>>>>> Well now...
>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 12 February 2017 at 22:50, Matt Sicker <boa...@gmail.com>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>> I've set up a basic test matrix for Java 7 and 8 on Linux and
>>>>>>>>>>>>>> Windows here: <https://builds.apache.org/job/Log4j/>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Let's see how this works.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 12 February 2017 at 22:40, Matt Sicker <boa...@gmail.com>
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>> I'm not really sure how to go about fixing the tests, but I was
>>>>>>>>>>>>>>> thinking of setting up a Jenkins job for multi-environment
>>>>>>>>>>>>>>> testing to try and catch these issues sooner.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On 12 February 2017 at 22:16, Gary Gregory
>>>>>>>>>>>>>>>> <garydgreg...@gmail.com> wrote:
>>>>>>>>>>>>>>>> Any chance building on Windows gets solved soon-ish?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Thu, Feb 2, 2017 at 6:05 PM, Gary Gregory
>>>>>>>>>>>>>>>>> <garydgreg...@gmail.com> wrote:
>>>>>>>>>>>>>>>>> Git bisec says:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a is the first bad
>>>>>>>>>>>>>>>>> commit
>>>>>>>>>>>>>>>>> commit a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a
>>>>>>>>>>>>>>>>> Author: Ralph Goers <ralph.go...@dslextreme.com>
>>>>>>>>>>>>>>>>> Date: Tue Jan 24 14:48:34 2017 -0700
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Use an ExecutorService to verify shutdown of the async
>>>>>>>>>>>>>>>>> threads
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> :040000 040000 ad3cb23efafeaab2f7e934e249c8e53ff7dcf86f
>>>>>>>>>>>>>>>>> 056bbb158f43602fb2a4e8c74c5bcff29e5e5fe5 M log4j-core
>>>>>>>>>>>>>>>>> bisect run success
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I'm not sure what needs to be reverted or changed but there
>>>>>>>>>>>>>>>>> you have it (I have to get back to a customer issue now).
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> If you want to do this yourself you can run:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> git bisect start HEAD log4j-2.7
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> (I was not sure how far back to go so I picked 2.7. It turns
>>>>>>>>>>>>>>>>> out I could have used 2.8. Then in a script called ..\run.cmd
>>>>>>>>>>>>>>>>> I have:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> call mvn clean
>>>>>>>>>>>>>>>>> call mvn -DskipTests -pl log4j-api install
>>>>>>>>>>>>>>>>> mvn -Dtest=RollingAppenderSizeTest -pl log4j-core test
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> and run:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> git bisect run ..\run.cmd
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> which gives you the output at the start of this message.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Thu, Feb 2, 2017 at 5:01 PM, Gary Gregory
>>>>>>>>>>>>>>>>>> <garydgreg...@gmail.com> wrote:
>>>>>>>>>>>>>>>>>> I get:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Tests in error:
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>> RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗
>>>>>>>>>>>>>>>>>> FileSystem target\rolli...
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Tests run: 1879, Failures: 0, Errors: 10, Skipped: 30
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> using:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Apache Maven 3.3.9
>>>>>>>>>>>>>>>>>> (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>>>>>>>>>>>>>>>>>> 2015-11-10T08:41:47-08:00)
>>>>>>>>>>>>>>>>>> Maven home: C:\Java\apache-maven-3.3.9\bin\..
>>>>>>>>>>>>>>>>>> Java version: 1.7.0_80, vendor: Oracle Corporation
>>>>>>>>>>>>>>>>>> Java home: C:\Program Files\Java\jdk1.7.0_80\jre
>>>>>>>>>>>>>>>>>> Default locale: en_US, platform encoding: Cp1252
>>>>>>>>>>>>>>>>>> OS name: "windows 8.1", version: "6.3", arch: "amd64",
>>>>>>>>>>>>>>>>>> family: "windows"
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Anyone else?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>>>>>>>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>>>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>>>>>>>>>>> Spring Batch in Action
>>>>>>>>>>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>>>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>>>>>>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>>>>>>>>>> Spring Batch in Action
>>>>>>>>>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>>>>>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>>>>>>>>> Spring Batch in Action
>>>>>>>>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Matt Sicker <boa...@gmail.com>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Matt Sicker <boa...@gmail.com>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Matt Sicker <boa...@gmail.com>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Matt Sicker <boa...@gmail.com>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Matt Sicker <boa...@gmail.com>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Matt Sicker <boa...@gmail.com>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>> Spring Batch in Action
>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Matt Sicker <boa...@gmail.com>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> JUnit in Action, Second Edition
>>>>>>> Spring Batch in Action
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> JUnit in Action, Second Edition
>>> Spring Batch in Action
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
