[
https://issues.apache.org/jira/browse/LOG4J2-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884087#comment-15884087
]
Remko Popma commented on LOG4J2-1807:
-------------------------------------
Looking at the code, I would suggest:
* removing the non-static Log4jLogEvent.createMemento() method. It is currently
not used, and it may create confusion for users: should they call
{{toImmutable}} or {{createMemento}}?
* removing the static Log4jLogEvent.createMemento(LogEvent) method. Current
callers (there's only 2) can be updated to call the {{createMemento(LogEvent
event, boolean includeLocation)}} method instead.
> [core] Add and implement LogEvent.toImmutable()
> -----------------------------------------------
>
> Key: LOG4J2-1807
> URL: https://issues.apache.org/jira/browse/LOG4J2-1807
> Project: Log4j 2
> Issue Type: New Feature
> Affects Versions: 2.8.1
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Attachments: logging-log4j2.patch
>
>
> [core] Add and implement LogEvent.asImmutable()
> {code:java}
> /**
> * Returns an immutable version of this log event, which MAY BE a copy of
> this event.
> *
> * @return an immutable version of this log event
> */
> LogEvent asImmutable();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
