Krzysztof Szymko created LOG4J2-1839:
----------------------------------------

             Summary: JdbcAppender.createAppender deprecated
                 Key: LOG4J2-1839
                 URL: https://issues.apache.org/jira/browse/LOG4J2-1839
             Project: Log4j 2
          Issue Type: Improvement
          Components: Appenders
    Affects Versions: 2.8.1
            Reporter: Krzysztof Szymko
             Fix For: 2.8.2


As I was migrating 2.7 to 2.8.1  I followed JdbcAppender.<B>newBuilder() API to 
build JDBC appender:        
 return JdbcAppender.<B>newBuilder()
            .setBufferSize(bufferSizeInt)
            .setColumnConfigs(columnConfigs)
            .setConnectionSource(connectionSource)
            .setTableName(tableName)
            .withName(name)
            .withIgnoreExceptions(ignoreExceptions)
            .withFilter(filter)
            .build();

But then I got NPE from JdbcDatabaseManagerFactory @ 275, since
I did not set any columnMappings. After providing 
.setColumnMappings(columnMappingJDBC)
to my builder it worked OK. I would suggest to either improve the javadoc or 
add NULL check in JdbcDatabaseManagerFactory.createManager
as JdbcAppender javadoc says that ColumnMapping is optional:

This Appender writes logging events to a relational database using standard 
JDBC mechanisms. It takes a list of
 * {@link ColumnConfig}s and/or {@link ColumnMapping}s with 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to