[
https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922740#comment-15922740
]
Mandy Chung commented on LOG4J2-1359:
-------------------------------------
See http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-March/046682.html
Are these benchmarks taking entire stack? StackWalker API improves the
performance of the use case when you walk the stack from the most recent
execution frame and stops when you reach a certain frame. Also the use case
when you want to look at the frame information such as classname/method name or
Class object. There is cost to get StackTraceElement is high that could be
improved.
The important thing is to replace the calls to
sun.reflect.Reflection.getCallerClass(int) with StackWalker::walk. I would
suggest to experiment doing the stack walk from the most recent frame and
determine any performance improvement.
> Add support for Java 9 StackWalker API in ReflectionUtil
> --------------------------------------------------------
>
> Key: LOG4J2-1359
> URL: https://issues.apache.org/jira/browse/LOG4J2-1359
> Project: Log4j 2
> Issue Type: Improvement
> Components: API
> Environment: Java 1.9+
> Reporter: Matt Sicker
> Assignee: Ralph Goers
> Labels: jdk9
>
> [StackWalker|http://download.java.net/jdk9/docs/api/java/lang/StackWalker.html]
> Based on the functional nature of this API, supporting it may require
> compiling at least one class using javac 1.9 and reflectively loading it in
> ReflectionUtil similar to how Spring supports newer JDK APIs.
> Without support for StackWalker, ReflectionUtil will fall back to using a
> slower API in Java 1.9. This is because the Reflection class is a
> sun-internal class which are no longer exported to non-JDK code without
> setting special command line flags.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
