[
https://issues.apache.org/jira/browse/LOG4J2-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924232#comment-15924232
]
Remko Popma commented on LOG4J2-1849:
-------------------------------------
I've started to look at this. The idea of FixedDateFormat is that by supporting
a subset of the SimpleDateFormat functionality we could get significant
performance gains. Of course daylight savings jumps need to be supported.
FixedDateFormat currently stores the TimeZone but does not do anything with it.
There is some pre-calculation that happens once every day to format the date
portion. I'm thinking to add logic there to look ahead at the hours of the
coming day and pre-calculate the DST savings as well.
If you're interested in making more contributions, I would really appreciate
more repeatable test cases since our current tests only failed on the day that
a DST change occurred.
> Broken FixedDateFormat tests when daylight saving time starts
> -------------------------------------------------------------
>
> Key: LOG4J2-1849
> URL: https://issues.apache.org/jira/browse/LOG4J2-1849
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.8.1
> Reporter: Matt Sicker
> Assignee: Remko Popma
>
> Today we started daylight saving time in the US, and the following tests
> failed:
> {noformat}
> Failed tests:
> FixedDateFormatTest.testFormatLong:162 ABSOLUTE(HH:mm:ss,SSS)/1489305608119
> expected:<0[3]:00:08,119> but was:<0[2]:00:08,119>
> FixedDateFormatTest.testFormatLongCharArrayInt:196
> ABSOLUTE(HH:mm:ss,SSS)/1489305607930 expected:<0[3]:00:07,930> but
> was:<0[2]:00:07,930>
> FixedDateFormatTest.testFormatLongCharArrayInt_goingBackInTime:214
> ABSOLUTE(HH:mm:ss,SSS)/1489381194091 expected:<2[3]:59:54,091> but
> was:<2[2]:59:54,091>
> FixedDateFormatTest.testFormatLong_goingBackInTime:178
> ABSOLUTE(HH:mm:ss,SSS)/1489381194072 expected:<2[3]:59:54,072> but
> was:<2[2]:59:54,072>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
