[ 
https://issues.apache.org/jira/browse/LOG4J2-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943021#comment-15943021
 ] 

ASF GitHub Bot commented on LOG4J2-1854:
----------------------------------------

Github user mikaelstaldal commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/67#discussion_r108137420
  
    --- Diff: 
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java 
---
    @@ -135,14 +136,17 @@ public DeflaterOutputStream 
createDeflaterOutputStream(final OutputStream os) th
             @PluginBuilderAttribute
             private boolean includeThreadContext = true;
     
    +        @PluginBuilderAttribute
    +        private boolean includeTcpMessageDelimiter = false;
    --- End diff --
    
    Maybe name this as `includeNullMessageDelimiter` to indicate what it does, 
rather than what is can be used for?


> Gelf TCP endpoint 
> ------------------
>
>                 Key: LOG4J2-1854
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1854
>             Project: Log4j 2
>          Issue Type: Bug
>            Reporter: Xavier Jodoin
>            Priority: Minor
>
> Gelf TCP endpoint need a NULL-byte between each messages and it doesn't 
> support compression



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to