[ 
https://issues.apache.org/jira/browse/LOG4J2-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962487#comment-15962487
 ] 

ASF GitHub Bot commented on LOG4J2-1864:
----------------------------------------

Github user codescale commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/62#discussion_r110581005
  
    --- Diff: 
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
 ---
    @@ -97,6 +103,8 @@ public String toString() {
         @PluginFactory
         public static MongoDbProvider createNoSqlProvider(
                 @PluginAttribute("collectionName") final String collectionName,
    +            @PluginAttribute(value = "capped", defaultBoolean = false) 
final Boolean isCapped,
    --- End diff --
    
    I took a look at the CassandraAppender. It's not a big deal to adjust the 
MongoDbProvider to match this style. But the API is also broken. Or do you 
intend to keep the old public methods? Shouldn't this even be another issues 
and pull-request?


> Support capped collection for MongoDB Log-Provider
> --------------------------------------------------
>
>                 Key: LOG4J2-1864
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1864
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Appenders
>            Reporter: Matt
>
> MongoDB supports sth. called capped collections. If the 
> nosql-mongodb-appender supports this feature, the mongodb-collection could 
> never "overflow" and stick to a defined maximum size.
> see [pull request 62|https://github.com/apache/logging-log4j2/pull/62] for 
> more details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to