I just added @since 2.7 to two places in RollingFileAppender.java. Gary
On Tue, Jan 16, 2018 at 2:26 PM, Ralph Goers <[email protected]> wrote: > We should make it a common practice to add @since tags on anything that > isn’t a 1.0 release. > > Ralph > > > On Jan 16, 2018, at 2:22 PM, Gary Gregory <[email protected]> > wrote: > > > > It looks like RollingFileAppender.Builder and RollingFileAppender. > newBuilder() > > were added for 2.7. > > > > Gary > > > > On Tue, Jan 16, 2018 at 1:31 PM, Mike Wertheim <[email protected]> > > wrote: > > > >> I'm working on a system that is composed of over a hundred > microservices, > >> and many of them are on various older versions of log4j2. > >> > >> There is an in-house library that many of the microservices share, and > the > >> library has some logging configuration code, so I'm trying to figure out > >> the relationship between that library and the various versions of > log4j2. > >> > >> > >> On Jan 16, 2018 12:16 PM, "Gary Gregory" <[email protected]> > wrote: > >> > >>> In general, you should be using the current version 2.10.0. Any reason > >> you > >>> are digging deep into old versions? > >>> > >>> Also, I've not been very strict about using @since in log4j-core. In > >>> log4j-api, we are very careful to do it all "right."" > >>> > >>> Gary > >>> > >>> On Tue, Jan 16, 2018 at 12:41 PM, Mike Wertheim < > [email protected] > >>> > >>> wrote: > >>> > >>>> https://logging.apache.org/log4j/2.x/log4j-core/apidocs/ > >>>> org/apache/logging/log4j/core/appender/RollingFileAppender.html > >>>> describes a method called "newBuilder". This method doesn't have a > >>> "since" > >>>> version, so I would assume that it's supported in all log4j2 versions. > >>>> > >>>> However, the expression RollingFileAppender.newBuilder() compiles > fine > >>>> with > >>>> version 2.7, but I get "error: cannot find symbol" when I try to > >> compile > >>> it > >>>> with version 2.6. > >>>> > >>>> Similarly.... According to > >>>> https://logging.apache.org/log4j/2.x/log4j-core/apidocs/ > >>>> org/apache/logging/log4j/core/appender/RollingFileAppender. > >> Builder.html, > >>>> it seems that the 'setConfiguration' method should be available in all > >>> 2.x > >>>> versions of log4j2. > >>>> > >>>> However, the expression > >>>> RollingFileAppender.newBuilder().setConfiguration(config).build() > >>> compiles > >>>> fine with version 2.10.0, but I get "error: cannot find symbol" when I > >>> try > >>>> to compile it with version 2.7. > >>>> > >>>> In both cases, it seems like the javadoc says that a method exists in > >> all > >>>> 2.x log4j2 versions, but that doesn't seem to be the case. Are these > >>>> methods only available in a subset of log4j2 versions? Is the javadoc > >>>> missing the "since version" information for these methods? > >>>> > >>> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
