Yoav, I agree with this approach. The only drawback is that you might need to duplicate your logging code. For example : MethodA and MethodB both call MethodC. MethodC finds an error and throw an exception. Then both MethodA and MethodB will need to log this error. And what if you have 50 methods calling MethodC? On the other hand if you log the error in MethodC then you have only one place that handles the logging for this error.
Don't get me wrong, with your approach (which is the one that I use in my code) you will have only one log for each error but the code might be harder to maintain. Raz. -----Original Message----- From: Shapira, Yoav [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 17, 2004 9:00 AM To: Log4J Users List Subject: RE: RE: when to log Exceptions Hi, >Exceptions are often caught and rethrown. If you're the end of the catching chain, i.e. if you don't rethrow it, log it. If you do rethrow it, no need to log because you're not really handling the exception. This approach is easy and will work with external libraries as well, without having to throw everything as your own exception with meta info like hasBeenLogged. Yoav Shapira This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
