Dave,
Thanks for your comments. The obvious mistakes you noted, they'll be corrected for the next edition. I'll try to rework the text so that it becomes clearer on the other points you raised.
There is a ANT build file to compile the examples. You don't need to invoke javac by hand.
At 07:59 PM 4/14/2005, you wrote:
Sent in a supportive manner.
The examples. If run on windows....
A batch file,
cd {wherever}/examples
javac -classpath ..\log4j-1.2.9.jar;. %1\%2.java java -cp ..\log4j-1.2.9.jar;. %1.%2 type *.log
del *.log
Helps with running the examples. I can't hack the 'type *.log' to make it work well on Linux.
javac -classpath ../lib/log4j-1.2.9.jar:. $1/$2.java java -cp ../lib/log4j-1.2.9.jar:. $1.$2
for the basic build.
p24. Bit confused over the levels. Is ALL | OFF included.. or not? I can't think of a way of expressing it better though. p28 shows the real hierarchy. That is clear.
p32. English. para 3. Suggest replace 'smaller' with 'less than' as being (maybe) more usual.
p34. Example 28 title. /AppendEx1 should be /AppenderEx1 p35. Example 29 title. /AppendEx2 should be /AppenderEx2
both these examples. I'd like to have seen (or noticed :-) the 'throws Exception'
I tried to add the FileAppender to an existing program, and received the warning that 'exception must be caught'.
Perhaps simplify and actually catch the exception? It was a nasty surprise to me :-)
(The additive inheritance is very well explained. I liked that)
p36. 'message parameter' (near bottom of page). First usage, has not been explained.
p37 Section headed 'A Peek under the hood'. May be of use to some. I found it too advanced for a new user. Perhaps it should be later in the book?
p39. Terminology. NDC MDC locationInformation. Not mentioned, Undefined, no reference to API.
p42. This section left me cold. I have no comprehension of ?? byte code ?? I'd suggest this is advanced log4j too.
So far so good. Well written and clear. The examples reinforce the text.
-- Regards,
Dave Pawson XSLT + Docbook FAQ http://www.dpawson.co.uk
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Ceki G�lc�
The complete log4j manual: http://www.qos.ch/log4j/
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
