I might be a good idea to allow Appenders to throw any exception. Having to catch and wrap checked exceptions is annoying.
On Thu, Jan 14, 2016 at 6:50 AM, Ralph Goers <[email protected]> wrote: > Why are you catching it at all? AppenderControl also takes care of > handling logging the exception so you don’t even have to catch the > exception to do that. > > Ralph > > > On Jan 13, 2016, at 7:49 PM, Nicholas Duane <[email protected]> wrote: > > > > Also, why would we not just rethrow whatever exception we caught? > > > > Thanks, > > Nick > > > >> Subject: Re: Appender's append() method > >> From: [email protected] > >> Date: Wed, 13 Jan 2016 17:28:11 -0700 > >> To: [email protected] > >> > >> Sorry, that was what I meant. > >> > >> Ralph > >> > >>> On Jan 13, 2016, at 3:17 PM, Gary Gregory <[email protected]> > wrote: > >>> > >>> IMO a RuntimeException subclass is appropriate while RuntimeException > >>> should not be used. > >>> > >>> Gary > >>> > >>> On Wed, Jan 13, 2016 at 1:53 PM, Ralph Goers < > [email protected]> > >>> wrote: > >>> > >>>> Your appender is automatically wrapped by an AppenderControl object. > The > >>>> AppenderControl will inspect the ignoreExceptions flag so your > Appender > >>>> does not have to. Your Appender should just throw a RuntimeException > if it > >>>> encounters a problem. > >>>> > >>>> Ralph > >>>> > >>>>> On Jan 13, 2016, at 2:38 PM, Nicholas Duane <[email protected]> wrote: > >>>>> > >>>>> I'm new to java so maybe this should be an obvious question to most > java > >>>> developers. If I'm trying to override the append() method but also > throw > >>>> exceptions, how is that done? > >>>>> > >>>>> I'm asking because I assume my append method's outermost catch block > is > >>>> to inspect the ignoreExceptions flag and either bubble up the > exception if > >>>> ignoreExceptions is false or eat the exception otherwise, most likely > just > >>>> logging an event. Is that true? If so, then how do I accomplish > that? I > >>>> tried coding it as I mentioned above (actually someone else did it > for me), > >>>> but the compiler I guess was complaining about the throw needing to > be in a > >>>> catch block, I assume because the append() method is not defined to > throw > >>>> exceptions. > >>>>> > >>>>> In addition, looking at what I think was source for one of your > >>>> appenders at: > >>>>> > >>>>> > >>>> > https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=blob;f=log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AbstractOutputStreamAppender.java;h=9a4cfde83194c866c30c4687e9f4ebb19cb20a17;hb=75d33d96ac00356014cf11f8ad9e8c6ead4db37a > >>>>> > >>>>> Why does it always throw an exception in the catch block instead of > >>>> checking the state of the ignoreExceptions flag? > >>>>> > >>>>> Thanks, > >>>>> Nick > >>>>> > >>>> > >>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>>> > >>> > >>> > >>> -- > >>> E-Mail: [email protected] | [email protected] > >>> Java Persistence with Hibernate, Second Edition > >>> <http://www.manning.com/bauer3/> > >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > >>> Spring Batch in Action <http://www.manning.com/templier/> > >>> Blog: http://garygregory.wordpress.com > >>> Home: http://garygregory.com/ > >>> Tweet! http://twitter.com/GaryGregory > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* [email protected] Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated in this message (or responsible for delivery of the message to such a person), you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email.
