nicko 2004/06/01 11:34:40
Modified: src/Appender ConsoleAppender.cs DebugAppender.cs
EventLogAppender.cs FileAppender.cs
TextWriterAppender.cs TraceAppender.cs
Log:
Marked all non default constructors as Obsolete.
The correct usage model for appenders is to create an instance using the
default constructor, set the properties on the instance and then call
ActivateOptions().
The alternative constructors represent a set of different and possible
incorrect initialisation paths.
Revision Changes Path
1.4 +2 -0 logging-log4net/src/Appender/ConsoleAppender.cs
Index: ConsoleAppender.cs
===================================================================
RCS file: /home/cvs/logging-log4net/src/Appender/ConsoleAppender.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ConsoleAppender.cs 23 Feb 2004 03:18:02 -0000 1.3
+++ ConsoleAppender.cs 1 Jun 2004 18:34:40 -0000 1.4
@@ -72,6 +72,7 @@
/// The instance of the <see cref="ConsoleAppender" /> class is
set up to write
/// to the standard output stream.
/// </remarks>
+ [Obsolete("Instead use the default constructor and set the
Layout property")]
public ConsoleAppender(ILayout layout) : this(layout, false)
{
}
@@ -87,6 +88,7 @@
/// the standard error output stream. Otherwise, output is
written to the standard
/// output stream.
/// </remarks>
+ [Obsolete("Instead use the default constructor and set the
Layout & Target properties")]
public ConsoleAppender(ILayout layout, bool writeToErrorStream)
{
Layout = layout;
1.4 +1 -0 logging-log4net/src/Appender/DebugAppender.cs
Index: DebugAppender.cs
===================================================================
RCS file: /home/cvs/logging-log4net/src/Appender/DebugAppender.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- DebugAppender.cs 23 Feb 2004 03:18:02 -0000 1.3
+++ DebugAppender.cs 1 Jun 2004 18:34:40 -0000 1.4
@@ -55,6 +55,7 @@
/// with a specified layout.
/// </summary>
/// <param name="layout">The layout to use with this
appender.</param>
+ [System.Obsolete("Instead use the default constructor and set
the Layout property")]
public DebugAppender(ILayout layout)
{
Layout = layout;
1.7 +1 -0 logging-log4net/src/Appender/EventLogAppender.cs
Index: EventLogAppender.cs
===================================================================
RCS file: /home/cvs/logging-log4net/src/Appender/EventLogAppender.cs,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- EventLogAppender.cs 30 May 2004 18:01:18 -0000 1.6
+++ EventLogAppender.cs 1 Jun 2004 18:34:40 -0000 1.7
@@ -72,6 +72,7 @@
/// with the specified <see cref="ILayout" />.
/// </summary>
/// <param name="layout">The <see cref="ILayout" /> to use with
this appender.</param>
+ [Obsolete("Instead use the default constructor and set the
Layout property")]
public EventLogAppender(ILayout layout) : this()
{
Layout = layout;
1.5 +2 -0 logging-log4net/src/Appender/FileAppender.cs
Index: FileAppender.cs
===================================================================
RCS file: /home/cvs/logging-log4net/src/Appender/FileAppender.cs,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- FileAppender.cs 30 May 2004 18:01:18 -0000 1.4
+++ FileAppender.cs 1 Jun 2004 18:34:40 -0000 1.5
@@ -58,6 +58,7 @@
/// <param name="layout">the layout to use with this
appender</param>
/// <param name="filename">the full path to the file to write
to</param>
/// <param name="append">flag to indicate if the file should be
appended to</param>
+ [Obsolete("Instead use the default constructor and set the
Layout, File, & AppendToFile properties")]
public FileAppender(ILayout layout, string filename, bool
append)
{
Layout = layout;
@@ -70,6 +71,7 @@
/// </summary>
/// <param name="layout">the layout to use with this
appender</param>
/// <param name="filename">the full path to the file to write
to</param>
+ [Obsolete("Instead use the default constructor and set the
Layout & File propertes")]
public FileAppender(ILayout layout, string filename) :
this(layout, filename, true)
{
}
1.4 +2 -0 logging-log4net/src/Appender/TextWriterAppender.cs
Index: TextWriterAppender.cs
===================================================================
RCS file: /home/cvs/logging-log4net/src/Appender/TextWriterAppender.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- TextWriterAppender.cs 23 Feb 2004 03:18:02 -0000 1.3
+++ TextWriterAppender.cs 1 Jun 2004 18:34:40 -0000 1.4
@@ -51,6 +51,7 @@
/// </summary>
/// <param name="layout">The layout to use with this
appender.</param>
/// <param name="os">The <see cref="Stream"/> to output
to.</param>
+ [Obsolete("Instead use the default constructor and set the
Layout & Writer properties")]
public TextWriterAppender(ILayout layout, Stream os) :
this(layout, new StreamWriter(os))
{
}
@@ -64,6 +65,7 @@
/// <remarks>
/// The <see cref="TextWriter" /> must have been previously
opened.
/// </remarks>
+ [Obsolete("Instead use the default constructor and set the
Layout & Writer properties")]
public TextWriterAppender(ILayout layout, TextWriter writer)
{
Layout = layout;
1.4 +1 -0 logging-log4net/src/Appender/TraceAppender.cs
Index: TraceAppender.cs
===================================================================
RCS file: /home/cvs/logging-log4net/src/Appender/TraceAppender.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- TraceAppender.cs 23 Feb 2004 03:18:02 -0000 1.3
+++ TraceAppender.cs 1 Jun 2004 18:34:40 -0000 1.4
@@ -64,6 +64,7 @@
/// with a specified layout.
/// </summary>
/// <param name="layout">The layout to use with this
appender.</param>
+ [System.Obsolete("Instead use the default constructor and set
the Layout property")]
public TraceAppender(ILayout layout)
{
Layout = layout;
