Scott, Extensibility of the PatternLayout is an issue with the 1.2 beta 8 code, however this has been addressed in the code in CVS. In fact the CVS version of PatternParser does not have a FinalizeConverter method.
The PatternLayout now supports long pattern names (i.e. longer than one character). Also patterns and PatternConverters can be added to a PatternLayout programmatically or through the config file. FYI the latest CVS version can be seen here: http://cvs.apache.org/viewcvs.cgi/logging-log4net/src/Util/PatternParser .cs?rev=1.3&view=markup Cheers, Nicko > -----Original Message----- > From: Scott Hanselman [mailto:[EMAIL PROTECTED] > Sent: 02 August 2004 18:07 > To: Log4NET Dev > Cc: Nicko Cadell > Subject: RE: Code submitting > > Nicko, > > I know this isn't the preferred way, but it's a one line thing. > > Could you change the FinalizeConverter(char c) method in > PatternParser.cs, line 237 to include the keyword "virtual"? > > Without this change, it is not possible to create your own > PatternParser given the current log4net source. I suspect > this is because all functions were virtual in Java, but not so in C#. > > Write up here: > http://www.hanselman.com/blog/PermaLink.aspx?guid=b04ee603-c73 > d-4320-973 > d-59977a16d23d > > Scott > > -----Original Message----- > From: Nicko Cadell [mailto:[EMAIL PROTECTED] > Sent: Friday, July 30, 2004 12:37 PM > To: Log4NET Dev > Subject: RE: Code submitting > > Ian, > > The dev list is the right place to contribute to the > development of log4net. > If you have enhancements/suggestions/bug fixes/new features > then post them here. > > If you are making changes to existing log4net code then the > preferred way is to supply a patch (in unified diff format) > against the latest CVS version of the source. You can do this > by running "cvs diff -u" against your local changes. If you > only have changes to a small number of files then the patches > should be submitted as a text email. If you have made changes > to many files then the changes should be packed into a zip. > > If you are submitting new code then just pack the files into > a zip and attach that to an email explaining what your code > does and why. > > Cheers, > > Nicko > > > -----Original Message----- > > From: Ian Kundil [mailto:[EMAIL PROTECTED] > > Sent: 30 July 2004 19:41 > > To: Log4NET Dev; [EMAIL PROTECTED] > > Subject: Code submitting > > > > Hi All > > Can any one explain me please what is the huge secret of code > > check-ins? > > How I'm sharing my changes with others? According with > license I must > > but it appears to be HUGE secret to do so. > > > > Thanks > > Ian > > > > >
