Jonathan,

Thanks for the patch, as far as I can tell the mailing list does not
like ZIP attachments but it seems to be ok with plain text files.
As far as building with NAnt you need to get a recent nightly build to
be able to build the CVS version of log4net, nant-0.85-20040729 is
working for me.

As far as I can see this patch means that the MS .NET 1.0 compiler would
be used to build all the assemblies. The log4net.csproj is in VS.NET
2002 format and VS.NET 2002 can only build with the .NET 1.0 framework.

Is building the .NET 1.1, NETCF, SSCLI and MONO assemblies using VS.NET
2002 and the .NET 1.0 framework the right thing to do? Presumably if the
frameworks are all ECMA CLI compliant then they should be able to load
the assemblies built under 1.0. However the MONO and SSCLI compilers
certainly produce different output and different debugging support
symbols. I'm not sure that the NETCF is compatible at all, it dose not
seem to be the easiest platform to develop on.

I'm not sure if I should commit this patch because the build output
would be different to that of the NAnt build and that would not be
obvious to users that wanted to recompile log4net. Also if the csproj
file is opened in VS.NET 2003 then it will be upgraded to use the 1.1
framework and all the build outputs will be build against the .NET 1.1
framework, this is a bad thing because then to use the output assemblies
on .NET 1.0 you need to add binding redirects to the application's
config file (they made this easier in .NET 1.1 but in 1.0 you have to
rebind all the referenced assemblies).

Thoughts?

Nicko

> -----Original Message-----
> From: Jonathan Beeston [mailto:[EMAIL PROTECTED] 
> Sent: 19 August 2004 16:18
> To: [email protected]
> Subject: Changes to VS.NET project files.
> 
> Hello.  I have made changes to the solution and project files 
> for log4net for VS.NET to allow all targets to be built.  I 
> have done this due to the fact that I have been having 
> trouble in building it using NAnt.  I have supplied the 
> changes using unified diff format below.  I have attempted to 
> post these changes in a zip but that got rejected.
> 
> 
> Index: log4net.sln
> ===================================================================
> RCS file: /home/cvspublic/logging-log4net/src/log4net.sln,v
> retrieving revision 1.3
> diff -u -r1.3 log4net.sln
> --- log4net.sln       26 Feb 2004 20:59:01 -0000      1.3
> +++ log4net.sln       19 Aug 2004 14:22:00 -0000
> @@ -8,24 +8,60 @@
>               DPCodeReviewSolutionGUID = 
> {00000000-0000-0000-0000-000000000000}
> 
>       EndGlobalSection
> 
>       GlobalSection(SolutionConfiguration) = preSolution
> 
> -             ConfigName.0 = Debug
> 
> -             ConfigName.1 = Release
> 
> +             Debug = Debug
> +             Debug .NET 1.1 = Debug .NET 1.1
> +             Debug .NET CF 1.0 = Debug .NET CF 1.0
> +             Debug MONO 1.0 = Debug MONO 1.0
> +             Debug SSCLI 1.0 = Debug SSCLI 1.0
> +             Release = Release
> +             Release .NET 1.1 = Release .NET 1.1
> +             Release .NET CF 1.0 = Release .NET CF 1.0
> +             Release MONO 1.0 = Release MONO 1.0
> +             Release SSCLI 1.0 = Release SSCLI 1.0
>       EndGlobalSection
> 
>       GlobalSection(ProjectDependencies) = postSolution
> 
>       EndGlobalSection
> 
>       GlobalSection(ProjectConfiguration) = postSolution
> 
> -             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug.ActiveCfg = Debug|.NET
> 
> -             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug.Build.0 = Debug|.NET
> 
> -             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Release.ActiveCfg = 
> Release|.NET
> 
> -             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Release.Build.0 = Release|.NET
> 
> -             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.ReleaseStrong.ActiveCfg
>  = ReleaseStrong|.NET
> 
> -             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.ReleaseStrong.Build.0 
> = ReleaseStrong|.NET
> 
> -             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug.ActiveCfg = Debug|.NET
> 
> -             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug.Build.0 = Debug|.NET
> 
> -             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release.ActiveCfg = 
> Release|.NET
> 
> -             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release.Build.0 = Release|.NET
> 
> -             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.ReleaseStrong.ActiveCfg
>  = Release|.NET
> 
> -             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.ReleaseStrong.Build.0 
> = Release|.NET
> 
> +             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug.ActiveCfg = Debug|.NET
> +             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug.Build.0 = Debug|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> .NET 1.1.ActiveCfg = Debug .NET 1.1|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> .NET 1.1.Build.0 = Debug .NET 1.1|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> .NET CF 1.0.ActiveCfg = Debug .NET CF 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> .NET CF 1.0.Build.0 = Debug .NET CF 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> MONO 1.0.ActiveCfg = Debug MONO 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> MONO 1.0.Build.0 = Debug MONO 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> SSCLI 1.0.ActiveCfg = Debug SSCLI 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Debug 
> SSCLI 1.0.Build.0 = Debug SSCLI 1.0|.NET
> +             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Release.ActiveCfg = 
> Release|.NET
> +             
> {F6A02431-167E-4347-BC43-65532C31CDB7}.Release.Build.0 = Release|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> .NET 1.1.ActiveCfg = Release .NET 1.1|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> .NET 1.1.Build.0 = Release .NET 1.1|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> .NET CF 1.0.ActiveCfg = Release .NET CF 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> .NET CF 1.0.Build.0 = Release .NET CF 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> MONO 1.0.ActiveCfg = Release MONO 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> MONO 1.0.Build.0 = Release MONO 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> SSCLI 1.0.ActiveCfg = Release SSCLI 1.0|.NET
> +             {F6A02431-167E-4347-BC43-65532C31CDB7}.Release 
> SSCLI 1.0.Build.0 = Release SSCLI 1.0|.NET
> +             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug.ActiveCfg = Debug|.NET
> +             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug.Build.0 = Debug|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> .NET 1.1.ActiveCfg = Debug .NET 1.1|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> .NET 1.1.Build.0 = Debug .NET 1.1|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> .NET CF 1.0.ActiveCfg = Debug .NET CF 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> .NET CF 1.0.Build.0 = Debug .NET CF 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> MONO 1.0.ActiveCfg = Debug MONO 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> MONO 1.0.Build.0 = Debug MONO 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> SSCLI 1.0.ActiveCfg = Debug SSCLI 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Debug 
> SSCLI 1.0.Build.0 = Debug SSCLI 1.0|.NET
> +             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release.ActiveCfg = 
> Release|.NET
> +             
> {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release.Build.0 = Release|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> .NET 1.1.ActiveCfg = Release .NET 1.1|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> .NET 1.1.Build.0 = Release .NET 1.1|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> .NET CF 1.0.ActiveCfg = Release .NET CF 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> .NET CF 1.0.Build.0 = Release .NET CF 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> MONO 1.0.ActiveCfg = Release MONO 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> MONO 1.0.Build.0 = Release MONO 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> SSCLI 1.0.ActiveCfg = Release SSCLI 1.0|.NET
> +             {4B68B77E-0C8B-4296-930D-6AC2787170B8}.Release 
> SSCLI 1.0.Build.0 = 
> +Release SSCLI 1.0|.NET
>       EndGlobalSection
> 
>       GlobalSection(ExtensibilityGlobals) = postSolution
> 
>       EndGlobalSection
> 
> 
> 
> Index: log4net.csproj
> ===================================================================
> RCS file: /home/cvspublic/logging-log4net/src/log4net.csproj,v
> retrieving revision 1.5
> diff -u -r1.5 log4net.csproj
> --- log4net.csproj    31 Jul 2004 14:41:48 -0000      1.5
> +++ log4net.csproj    19 Aug 2004 14:22:23 -0000
> @@ -18,43 +18,187 @@
>                  OutputType = "Library"
> 
>                  RootNamespace = "log4net"
> 
>                  StartupObject = ""
> 
> -            >
> 
> -                <Config
> 
> -                    Name = "Debug"
> 
> -                    AllowUnsafeBlocks = "false"
> 
> -                    BaseAddress = "285212672"
> 
> -                    CheckForOverflowUnderflow = "false"
> 
> -                    ConfigurationOverrideFile = ""
> 
> -                    DefineConstants = "DEBUG;TRACE;NET;NET_1_0"
> 
> -                    DocumentationFile = "log4net.xml"
> 
> -                    DebugSymbols = "true"
> 
> -                    FileAlignment = "4096"
> 
> -                    IncrementalBuild = "true"
> 
> -                    Optimize = "false"
> 
> -                    OutputPath = "..\build\bin\net\1.0\debug\"
> 
> -                    RegisterForComInterop = "false"
> 
> -                    RemoveIntegerChecks = "false"
> 
> -                    TreatWarningsAsErrors = "false"
> 
> -                    WarningLevel = "4"
> 
> -                />
> 
> -                <Config
> 
> -                    Name = "Release"
> 
> -                    AllowUnsafeBlocks = "false"
> 
> -                    BaseAddress = "285212672"
> 
> -                    CheckForOverflowUnderflow = "false"
> 
> -                    ConfigurationOverrideFile = ""
> 
> -                    DefineConstants = "TRACE;STRONG;NET;NET_1_0;"
> 
> -                    DocumentationFile = "log4net.xml"
> 
> -                    DebugSymbols = "false"
> 
> -                    FileAlignment = "4096"
> 
> -                    IncrementalBuild = "true"
> 
> -                    Optimize = "true"
> 
> -                    OutputPath = "..\build\bin\net\1.0\release\"
> 
> -                    RegisterForComInterop = "false"
> 
> -                    RemoveIntegerChecks = "false"
> 
> -                    TreatWarningsAsErrors = "false"
> 
> -                    WarningLevel = "4"
> 
> -                />
> 
> +            >
> +                <Config
> +                    Name = "Debug"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "DEBUG;TRACE;NET;NET_1_0"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "true"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "false"
> +                    OutputPath = "..\build\bin\net\1.0\debug\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Release"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "TRACE;STRONG;NET;NET_1_0;"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "false"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "true"
> +                    OutputPath = "..\build\bin\net\1.0\release\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Release .NET 1.1"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "TRACE;STRONG;NET;NET_1_1;"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "false"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "true"
> +                    OutputPath = "..\build\bin\net\1.1\release\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Debug .NET 1.1"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "DEBUG;TRACE;NET;NET_1_1"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "true"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "false"
> +                    OutputPath = "..\build\bin\net\1.1\debug\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Release .NET CF 1.0"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "TRACE;STRONG;NETCF;NETCF_1_0;"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "false"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "true"
> +                    OutputPath = "..\build\bin\netcf\1.0\release\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Debug .NET CF 1.0"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "DEBUG;TRACE;NETCF;NETCF_1_0"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "true"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "false"
> +                    OutputPath = "..\build\bin\netcf\1.0\debug\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Release SSCLI 1.0"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "TRACE;STRONG;SSCLI;SSCLI_1_0;"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "false"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "true"
> +                    OutputPath = "..\build\bin\sscli\1.0\release\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Debug SSCLI 1.0"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "DEBUG;TRACE;SSCLI;SSCLI_1_0"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "true"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "false"
> +                    OutputPath = "..\build\bin\sscli\1.0\debug\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Release MONO 1.0"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "TRACE;STRONG;MONO;MONO_1_0;"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "false"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "true"
> +                    OutputPath = "..\build\bin\mono\1.0\release\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
> +                <Config
> +                    Name = "Debug MONO 1.0"
> +                    AllowUnsafeBlocks = "false"
> +                    BaseAddress = "285212672"
> +                    CheckForOverflowUnderflow = "false"
> +                    ConfigurationOverrideFile = ""
> +                    DefineConstants = "DEBUG;TRACE;MONO;MONO_1_0"
> +                    DocumentationFile = "log4net.xml"
> +                    DebugSymbols = "true"
> +                    FileAlignment = "4096"
> +                    IncrementalBuild = "true"
> +                    Optimize = "false"
> +                    OutputPath = "..\build\bin\mono\1.0\debug\"
> +                    RegisterForComInterop = "false"
> +                    RemoveIntegerChecks = "false"
> +                    TreatWarningsAsErrors = "false"
> +                    WarningLevel = "4"
> +                />
>              </Settings>
> 
>              <References>
> 
>                  <Reference
> 
> 
> -----------------------------------------
> Email provided by http://www.ntlhome.com/
> 
> 
> 

Reply via email to