Hi Nicko,

The changes you committed look great.  The "move file" trick before
delete was very clever and should help.  I also see you've eliminated
lots of new FileInfo objects, opting instead for the static methods that
let you check the same properties.  This should help elminate memory use
during logging with lots of file I/O.

Good job, and thanks!

-Doug

-----Original Message-----
From: Nicko Cadell [mailto:[EMAIL PROTECTED] 
Sent: Saturday, September 18, 2004 9:41 AM
To: Log4NET Dev
Subject: RE: cvs commit: logging-log4net/src/Appender FileAppender.cs
RollingFileAppender.cs TextWriterAppender.cs

Doug,

These updates should cover all the same points from you patch, but I did
a few things differently so you may want to check to make sure that I
haven't missed out anything.

It's probably easier to see the changes using the viewcvs diffs than
reading the changelog diffs:

http://cvs.apache.org/viewcvs.cgi/logging-log4net/src/Appender/

Cheers,
Nicko 

Reply via email to